Filtering the secret in the patcher logs

Author: Szczyrk

Assets/PatchKit Patcher/Scripts/Debug/UnityMessageWriter.cs

@@ -18,7 +18,9 @@ public UnityMessageWriter([NotNull] IMessageFormatter formatter)
 
         public void Write(Message message, MessageContext messageContext)
         {
-            var text = _formatter.Format(message, messageContext);
+            var patcher = Patcher.Instance;
+            var text = _formatter.Format(message, messageContext)
+                .Replace(patcher.AppSecret, patcher.TraceableAppSecret);
 
             switch (message.Type)
             {

Assets/PatchKit Patcher/Scripts/Patcher.cs

@@ -87,6 +87,10 @@ public static Patcher Instance
 
         private PatchKit.Unity.Patcher.Cancellation.CancellationTokenSource _updateAppCancellationTokenSource;
 
+        public string TraceableAppSecret { get; private set; }
+        
+        public string AppSecret { get; private set; }
+        
         public ErrorDialog ErrorDialog;
 
         public string EditorAppSecret;
@@ -512,7 +516,9 @@ private void ThreadLoadPatcherData()
                 var inputArgumentsPatcherDataReader = new InputArgumentsPatcherDataReader();
                 _data.Value = inputArgumentsPatcherDataReader.Read();
 #endif
-                DebugLogger.LogVariable(_data.Value.AppSecret, "Data.AppSecret");
+                AppSecret = _data.Value.AppSecret;
+                BuildTraceableAppSecret(AppSecret);
+                DebugLogger.LogVariable(AppSecret, "Data.AppSecret");
                 DebugLogger.LogVariable(_data.Value.AppDataPath, "Data.AppDataPath");
                 DebugLogger.LogVariable(_data.Value.OverrideLatestVersionId, "Data.OverrideLatestVersionId");
                 DebugLogger.LogVariable(_data.Value.LockFilePath, "Data.LockFilePath");
@@ -953,5 +959,11 @@ private bool ThreadTryRestartWithRequestForPermissions()
                 return false;
             }
         }
+        
+        private void BuildTraceableAppSecret(string appSecret)
+        {
+            TraceableAppSecret = string.Format("{0}...{1}", appSecret.Substring(0, 6),
+                appSecret.Substring(appSecret.Length - 6));
+        }
     }
 }

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [3.17.3.0]
+### Added
+- Filtering the secret in the patcher logs (#2040)
+
 ## [3.17.2.0]
 ### Added
 - Attempting to repair content on failed installation