Fix problem with remaining ".app" directories on Mac OSX

Author: witcher112

Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/InstallDiffCommand.cs

@@ -6,6 +6,7 @@
 using PatchKit.Unity.Patcher.Cancellation;
 using PatchKit.Unity.Patcher.Debug;
 using PatchKit.Unity.Patcher.Status;
+using PatchKit.Unity.Utilities;
 
 namespace PatchKit.Unity.Patcher.AppUpdater.Commands
 {
@@ -112,6 +113,7 @@ public override void Execute(CancellationToken cancellationToken)
                 ProcessAddedFiles(packageDirPath, cancellationToken);
                 ProcessRemovedFiles(cancellationToken);
                 ProcessModifiedFiles(packageDirPath, cancellationToken);
+                DeleteEmptyMacAppDirectories();
             }
             finally
             {
@@ -253,6 +255,31 @@ private void ProcessModifiedFiles(string packageDirPath,
 
             _modifiedFilesStatusReporter.OnProgressChanged(1.0);
         }
+        
+        // TODO: Temporary solution for situation when .app directory is not deleted
+        private void DeleteEmptyMacAppDirectories()
+        {
+            if (Platform.IsOSX())
+            {
+                DebugLogger.Log("Deleting empty Mac OSX '.app' directories...");
+            
+                var appDirectories = Directory
+                    .GetFileSystemEntries(_localData.Path)
+                    .Where(s => Directory.Exists(s) &&
+                                s.EndsWith(".app") &&
+                                Directory.GetFiles(s, "*", SearchOption.AllDirectories).Length == 0);
+
+                foreach (var dir in appDirectories)
+                {
+                    if (Directory.Exists(dir))
+                    {
+                        DirectoryOperations.Delete(dir, true);
+                    }
+                }
+            
+                DebugLogger.Log("Empty Mac OSX '.app' directories has been deleted.");
+            }
+        }
 
         private void PatchFile(string fileName, string packageDirPath)
         {

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Moving files after installation instead of copying them
 - Fix keys API connection problem
 - Fix API cache usage problems
+- Fix problem with remaining ".app" directories on Mac OSX
 
 ## [3.1.4]
 ### Fixed