Merge branch 'master' into release

Author: witcher112

Assets/PatchKit Patcher/Scripts/AppData/Remote/WebRequestWraps/WrapRequest.cs

@@ -4,11 +4,15 @@
 using System.Threading;
 using UnityEngine;
 using PatchKit.Api;
+using PatchKit.Unity.Patcher.Debug;
+using ILogger = PatchKit.Logging.ILogger;
 
 namespace PatchKit.Unity.Patcher.AppData.Remote
 {
     public class WrapRequest : IHttpWebRequest
     {
+        private static readonly DebugLogger DebugLogger = new DebugLogger(typeof(WrapRequest));
+
         public const string ResponseEncoding = "iso-8859-2";
 
         private readonly EventWaitHandle _waitHandle;
@@ -39,10 +43,38 @@ private IEnumerator JobCoroutine(string url)
             {
                 _data = www.text;
 
-                if (!TryParseStatusCode(www.responseHeaders["STATUS"], out _statusCode))
+                try
+                {
+                    // HACK: because WWW is broken and sometimes just does not return STATUS in responseHeaders we are returning status code 200 (we can assume that status code is not an error since www.error is null or empty).
+                    if (!www.responseHeaders.ContainsKey("STATUS"))
+                    {
+                        DebugLogger.LogWarning("Response headers doesn't contain status information. Since WWW marks response as one without errors, status code is set to 200 (OK).");
+                        _statusCode = 200;
+                    }
+                    else
+                    {
+                        var status = www.responseHeaders["STATUS"];
+                        DebugLogger.Log(string.Format("Response status: {0}", status));
+                        var s = status.Split(' ');
+
+                        if (s.Length >= 3 && int.TryParse(s[1], out _statusCode))
+                        {
+                            DebugLogger.Log(string.Format("Successfully parsed status code: {0}", _statusCode));
+                        }
+                        else
+                        {
+                            // HACK: Again, we can't parse the status code (it might be in some different format) - so we simply set it to 200.
+                            DebugLogger.LogWarning(
+                                "Unable to parse status code. Since WWW marks response as one without errors, status code is set to 200 (OK).");
+                            _statusCode = 200;
+                        }
+                    }
+
+                }
+                catch (Exception e)
                 {
                     _wasError = true;
-                    _errorText = "Couldn't parse status code.";
+                    _errorText = e.ToString();
                 }
             }
             else
@@ -79,14 +111,5 @@ public IHttpWebResponse GetResponse()
 
             return new WrapResponse(_data, _statusCode, ResponseEncoding);
         }
-
-        private static bool TryParseStatusCode(string status, out int statusCode)
-        {
-            statusCode = 0;
-
-            var s = status.Split(' ');
-
-            return s.Length >= 3 && int.TryParse(s[1], out statusCode);
-        }
     }
 }