Skip to content

Commit a10ca34

Browse files
authored
feat(drawer): add no-glass panel variant, test (#12125)
* feat(drawer): add no-glass panel variant, test * chore: fix docs, test * chore: add beta to hasNoGlass
1 parent a88ecfa commit a10ca34

File tree

8 files changed

+28
-14
lines changed

8 files changed

+28
-14
lines changed

packages/react-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"tslib": "^2.8.1"
5555
},
5656
"devDependencies": {
57-
"@patternfly/patternfly": "6.5.0-prerelease.14",
57+
"@patternfly/patternfly": "6.5.0-prerelease.19",
5858
"case-anything": "^3.1.2",
5959
"css": "^3.0.0",
6060
"fs-extra": "^11.3.0"

packages/react-core/src/components/Drawer/DrawerPanelContent.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ export interface DrawerPanelContentProps extends Omit<React.HTMLProps<HTMLDivEle
3535
hasNoBorder?: boolean;
3636
/** Flag indicating that the drawer panel should be resizable. */
3737
isResizable?: boolean;
38+
/** @beta Flag indicating that the drawer panel should disable glass styles. This prop is intended to work with isPill drawers. */
39+
hasNoGlass?: boolean;
3840
/** Callback for resize end. */
3941
onResize?: (event: MouseEvent | TouchEvent | React.KeyboardEvent, width: number, id: string) => void;
4042
/** The minimum size of a drawer. */
@@ -68,6 +70,7 @@ export const DrawerPanelContent: React.FunctionComponent<DrawerPanelContentProps
6870
children,
6971
hasNoBorder = false,
7072
isResizable = false,
73+
hasNoGlass = false,
7174
onResize,
7275
minSize,
7376
defaultSize,
@@ -364,6 +367,7 @@ export const DrawerPanelContent: React.FunctionComponent<DrawerPanelContentProps
364367
className={css(
365368
styles.drawerPanel,
366369
isResizable && styles.modifiers.resizable,
370+
hasNoGlass && styles.modifiers.noGlass,
367371
hasNoBorder && styles.modifiers.noBorder,
368372
formatBreakpointMods(widths, styles),
369373
colorVariant === DrawerColorVariant.noBackground && styles.modifiers.noBackground,

packages/react-core/src/components/Drawer/__tests__/DrawerPanelContent.test.tsx

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,3 +158,13 @@ test('Style prop overrides boundaryCssVars', () => {
158158
'--pf-v6-c-drawer__panel--md--FlexBasis--max': '500px'
159159
});
160160
});
161+
162+
test(`Renders with class ${styles.modifiers.noGlass} when isPill is true`, () => {
163+
render(
164+
<Drawer isExpanded isPill>
165+
<DrawerPanelContent hasNoGlass>Drawer panel content</DrawerPanelContent>
166+
</Drawer>
167+
);
168+
169+
expect(screen.getByText('Drawer panel content')).toHaveClass(styles.modifiers.noGlass);
170+
});

packages/react-docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"test:a11y": "patternfly-a11y --config patternfly-a11y.config"
2424
},
2525
"dependencies": {
26-
"@patternfly/patternfly": "6.5.0-prerelease.14",
26+
"@patternfly/patternfly": "6.5.0-prerelease.19",
2727
"@patternfly/react-charts": "workspace:^",
2828
"@patternfly/react-code-editor": "workspace:^",
2929
"@patternfly/react-core": "workspace:^",

packages/react-icons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"@fortawesome/free-brands-svg-icons": "^5.15.4",
3434
"@fortawesome/free-regular-svg-icons": "^5.15.4",
3535
"@fortawesome/free-solid-svg-icons": "^5.15.4",
36-
"@patternfly/patternfly": "6.5.0-prerelease.14",
36+
"@patternfly/patternfly": "6.5.0-prerelease.19",
3737
"fs-extra": "^11.3.0",
3838
"tslib": "^2.8.1"
3939
},

packages/react-styles/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"clean": "rimraf dist css"
2020
},
2121
"devDependencies": {
22-
"@patternfly/patternfly": "6.5.0-prerelease.14",
22+
"@patternfly/patternfly": "6.5.0-prerelease.19",
2323
"change-case": "^5.4.4",
2424
"fs-extra": "^11.3.0"
2525
},

packages/react-tokens/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
"devDependencies": {
3232
"@adobe/css-tools": "^4.4.4",
33-
"@patternfly/patternfly": "6.5.0-prerelease.14",
33+
"@patternfly/patternfly": "6.5.0-prerelease.19",
3434
"fs-extra": "^11.3.0"
3535
}
3636
}

yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4516,10 +4516,10 @@ __metadata:
45164516
languageName: node
45174517
linkType: hard
45184518

4519-
"@patternfly/patternfly@npm:6.5.0-prerelease.14":
4520-
version: 6.5.0-prerelease.14
4521-
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.14"
4522-
checksum: 10c0/d2bca43a2b4c98767b81dc5569eb5960866c9e7b757276b69aa8eacc06414723e3a58b434c7f1b46e416fe02474dbc333707e6c6a82ca05201900458d74ca548
4519+
"@patternfly/patternfly@npm:6.5.0-prerelease.19":
4520+
version: 6.5.0-prerelease.19
4521+
resolution: "@patternfly/patternfly@npm:6.5.0-prerelease.19"
4522+
checksum: 10c0/581e18b078e146ad72553f8fb1177ffe84e7bfbeb5920f8e7ce7da22dd9c9334fee850cf7e8fe274a8dee72a9b1608aad5cbcc5679b52275970e2801669f56ab
45234523
languageName: node
45244524
linkType: hard
45254525

@@ -4617,7 +4617,7 @@ __metadata:
46174617
version: 0.0.0-use.local
46184618
resolution: "@patternfly/react-core@workspace:packages/react-core"
46194619
dependencies:
4620-
"@patternfly/patternfly": "npm:6.5.0-prerelease.14"
4620+
"@patternfly/patternfly": "npm:6.5.0-prerelease.19"
46214621
"@patternfly/react-icons": "workspace:^"
46224622
"@patternfly/react-styles": "workspace:^"
46234623
"@patternfly/react-tokens": "workspace:^"
@@ -4638,7 +4638,7 @@ __metadata:
46384638
resolution: "@patternfly/react-docs@workspace:packages/react-docs"
46394639
dependencies:
46404640
"@patternfly/documentation-framework": "npm:^6.28.9"
4641-
"@patternfly/patternfly": "npm:6.5.0-prerelease.14"
4641+
"@patternfly/patternfly": "npm:6.5.0-prerelease.19"
46424642
"@patternfly/patternfly-a11y": "npm:5.1.0"
46434643
"@patternfly/react-charts": "workspace:^"
46444644
"@patternfly/react-code-editor": "workspace:^"
@@ -4678,7 +4678,7 @@ __metadata:
46784678
"@fortawesome/free-brands-svg-icons": "npm:^5.15.4"
46794679
"@fortawesome/free-regular-svg-icons": "npm:^5.15.4"
46804680
"@fortawesome/free-solid-svg-icons": "npm:^5.15.4"
4681-
"@patternfly/patternfly": "npm:6.5.0-prerelease.14"
4681+
"@patternfly/patternfly": "npm:6.5.0-prerelease.19"
46824682
fs-extra: "npm:^11.3.0"
46834683
tslib: "npm:^2.8.1"
46844684
peerDependencies:
@@ -4763,7 +4763,7 @@ __metadata:
47634763
version: 0.0.0-use.local
47644764
resolution: "@patternfly/react-styles@workspace:packages/react-styles"
47654765
dependencies:
4766-
"@patternfly/patternfly": "npm:6.5.0-prerelease.14"
4766+
"@patternfly/patternfly": "npm:6.5.0-prerelease.19"
47674767
change-case: "npm:^5.4.4"
47684768
fs-extra: "npm:^11.3.0"
47694769
languageName: unknown
@@ -4805,7 +4805,7 @@ __metadata:
48054805
resolution: "@patternfly/react-tokens@workspace:packages/react-tokens"
48064806
dependencies:
48074807
"@adobe/css-tools": "npm:^4.4.4"
4808-
"@patternfly/patternfly": "npm:6.5.0-prerelease.14"
4808+
"@patternfly/patternfly": "npm:6.5.0-prerelease.19"
48094809
fs-extra: "npm:^11.3.0"
48104810
languageName: unknown
48114811
linkType: soft

0 commit comments

Comments
 (0)