disable mypy, fix more warnings

Author: leiterrl

.pre-commit-config.yaml

@@ -40,20 +40,20 @@ repos:
         args: [--prose-wrap=always]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.1.14"
+    rev: "v0.8.4"
     hooks:
       - id: ruff
         args: ["--fix", "--show-fixes"]
       - id: ruff-format
 
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: "v1.8.0"
-    hooks:
-      - id: mypy
-        files: pdebench|tests
-        args: []
-        additional_dependencies:
-          - pytest
+  # - repo: https://github.com/pre-commit/mirrors-mypy
+  #   rev: "v1.8.0"
+  #   hooks:
+  #     - id: mypy
+  #       files: pdebench|tests
+  #       args: []
+  #       additional_dependencies:
+  #         - pytest
 
   - repo: https://github.com/codespell-project/codespell
     rev: "v2.2.6"
@@ -62,7 +62,7 @@ repos:
         exclude_types: [jupyter]
 
   - repo: https://github.com/shellcheck-py/shellcheck-py
-    rev: "v0.9.0.6"
+    rev: "v0.10.0.1"
     hooks:
       - id: shellcheck
 

pdebench/__init__.py

@@ -29,4 +29,4 @@
 
 __version__ = "0.0.1"
 __author__ = "Makoto Takamoto, Timothy Praditia, Raphael Leiteritz, Dan MacKinlay, Francesco Alesiani, Dirk Pflüger, Mathias Niepert"
-__credits__ = "NEC labs Europe, University of Stuttgart, CSIRO" "s Data61"
+__credits__ = "NEC labs Europe, University of Stuttgart, CSIRO's Data61"

pdebench/data_gen/src/data_io.py

@@ -85,7 +85,7 @@ def to_ndarray(field: Field) -> np.ndarray:
     """
     centered = to_centre_grid(field)
     order = _get_dim_order(centered.shape)
-    return centered.values.numpy(order=order)  # noqa: PD011
+    return centered.values.numpy(order=order)
 
 
 def dataverse_upload(

pdebench/models/run_forward_1D.sh

@@ -62,12 +62,12 @@ CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d
 CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Advection_Sols_beta1.0.hdf5' ++args.aux_params=[1.]
 CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Advection_Sols_beta4.0.hdf5' ++args.aux_params=[4.]
 # Reaction Diffusion
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu0.5_Rho1.0.hdf5' ++args.aux_params=[0.5,1.] ++args.val_time=0.5
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu0.5_Rho10.0.hdf5' ++args.aux_params=[0.5,10.] ++args.val_time=0.5
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu2.0_Rho1.0.hdf5' ++args.aux_params=[2.,1.] ++args.val_time=0.5
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu2.0_Rho10.0.hdf5' ++args.aux_params=[2.,10.] ++args.val_time=0.5
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu0.5_Rho1.0.hdf5' ++args.aux_params="[0.5,1.]" ++args.val_time=0.5
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu0.5_Rho10.0.hdf5' ++args.aux_params="[0.5,10.]" ++args.val_time=0.5
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu2.0_Rho1.0.hdf5' ++args.aux_params="[2.,1.]" ++args.val_time=0.5
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='ReacDiff_Nu2.0_Rho10.0.hdf5' ++args.aux_params="[2.,10.]" ++args.val_time=0.5
 # Burgers Eq.
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu0.001.hdf5' ++args.aux_params=[0.001]
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu0.01.hdf5' ++args.aux_params=[0.01]
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu0.1.hdf5' ++args.aux_params=[0.1]
-CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu1.0.hdf5' ++args.aux_params=[1.]
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu0.001.hdf5' ++args.aux_params="[0.001]"
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu0.01.hdf5' ++args.aux_params="[0.01]"
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu0.1.hdf5' ++args.aux_params="[0.1]"
+CUDA_VISIBLE_DEVICES='0' python3 train_models_forward.py +args=config_pinn_pde1d.yaml ++args.filename='1D_Burgers_Sols_Nu1.0.hdf5' ++args.aux_params="[1.]"

pyproject.toml

@@ -172,11 +172,12 @@ ignore = [
   "PLR2004",  # Magic value used in comparison
   "ISC001",   # Conflicts with formatter
   "UP007",
-  "ARG001", # too many false positives 
-  "ARG005", 
+  "ARG001", # too many false positives
+  "ARG005",
   "E731", # do not assign a lambda expression, use a def
   "G004",
   "PD008", # dataframe confused with jax array
+  "PD011", # dataframe confused with jax array
 ]
 isort.required-imports = ["from __future__ import annotations"]
 # Uncomment if using a _compat.typing backport