Skip to content

Commit 02faa1e

Browse files
author
Craig Walls
committed
Fix broken FacebookAdapterTest to properly test for user profile link.
1 parent 2698d52 commit 02faa1e

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

spring-social-facebook/src/test/java/org/springframework/social/facebook/connect/FacebookAdapterTest.java

+11-4
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,14 @@
1717

1818
import static org.junit.Assert.*;
1919

20+
import java.lang.reflect.Field;
21+
2022
import org.junit.Test;
2123
import org.mockito.Mockito;
2224
import org.springframework.social.connect.ConnectionValues;
2325
import org.springframework.social.connect.UserProfile;
2426
import org.springframework.social.facebook.api.Facebook;
27+
import org.springframework.social.facebook.api.GraphApi;
2528
import org.springframework.social.facebook.api.User;
2629
import org.springframework.social.facebook.api.UserOperations;
2730

@@ -45,15 +48,19 @@ public void fetchProfile() {
4548
}
4649

4750
@Test
48-
public void setConnectionValues() {
51+
public void setConnectionValues() throws Exception {
4952
UserOperations userOperations = Mockito.mock(UserOperations.class);
5053
Mockito.when(facebook.userOperations()).thenReturn(userOperations);
51-
Mockito.when(userOperations.getUserProfile()).thenReturn(new User("12345678", "Craig Walls", "Craig", "Walls", null, null));
54+
User user = new User("12345678", "Craig Walls", "Craig", "Walls", null, null);
55+
Field linkField = user.getClass().getDeclaredField("link");
56+
linkField.setAccessible(true);
57+
linkField.set(user, "http://www.facebook.com/975041837");
58+
Mockito.when(userOperations.getUserProfile()).thenReturn(user);
5259
TestConnectionValues connectionValues = new TestConnectionValues();
5360
apiAdapter.setConnectionValues(facebook, connectionValues);
5461
assertEquals("Craig Walls", connectionValues.getDisplayName());
55-
assertEquals("https://graph.facebook.com/12345678/picture", connectionValues.getImageUrl());
56-
assertEquals("https://www.facebook.com/app_scoped_user_id/12345678/", connectionValues.getProfileUrl());
62+
assertEquals(GraphApi.GRAPH_API_URL + "12345678/picture", connectionValues.getImageUrl());
63+
assertEquals("http://www.facebook.com/975041837", connectionValues.getProfileUrl());
5764
assertEquals("12345678", connectionValues.getProviderUserId());
5865
}
5966

0 commit comments

Comments
 (0)