Skip to content

Commit 709663b

Browse files
authored
Merge pull request #16107 from phalcon/reflection-get-doc-comment
Adjust condition of `getDocComment()`
2 parents 9ae791e + a1467ab commit 709663b

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

phalcon/Annotations/Reader.zep

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class Reader implements ReaderInterface
3636
let reflection = new ReflectionClass(className);
3737

3838
let comment = reflection->getDocComment();
39-
if typeof comment == "string" {
39+
if comment !== false {
4040
/**
4141
* Read annotations from class
4242
*/
@@ -73,8 +73,7 @@ class Reader implements ReaderInterface
7373
*/
7474
let constantReflection = reflection->getReflectionConstant(constant);
7575
let comment = constantReflection->getDocComment();
76-
77-
if typeof comment === "string" {
76+
if comment !== false {
7877
/**
7978
* Parse constant docblock comment
8079
*/
@@ -112,8 +111,7 @@ class Reader implements ReaderInterface
112111
* Read comment from property
113112
*/
114113
let comment = property->getDocComment();
115-
116-
if typeof comment === "string" {
114+
if comment !== false {
117115
/**
118116
* Parse property docblock comment
119117
*/
@@ -139,16 +137,15 @@ class Reader implements ReaderInterface
139137
*/
140138
let methods = reflection->getMethods();
141139

142-
if count(methods) {
140+
if false === empty(methods) {
143141
let annotationsMethods = [];
144142

145143
for method in methods {
146144
/**
147145
* Read comment from method
148146
*/
149147
let comment = method->getDocComment();
150-
151-
if typeof comment == "string" {
148+
if comment !== false {
152149
/**
153150
* Parse method docblock comment
154151
*/
@@ -158,7 +155,7 @@ class Reader implements ReaderInterface
158155
method->getStartLine()
159156
);
160157

161-
if typeof methodAnnotations == "array" {
158+
if typeof methodAnnotations === "array" {
162159
let annotationsMethods[method->name] = methodAnnotations;
163160
}
164161
}

0 commit comments

Comments
 (0)