[#.0.x] - fixed getSpecial() for stable version

Author: niden

phalcon/Support/Version.zep

@@ -85,7 +85,7 @@ class Version
      */
     protected final function getSpecial(int special) -> string
     {
-        string suffix = "";
+        var suffix;
 
         switch special {
             case 1:
@@ -97,6 +97,9 @@ class Version
             case 3:
                 let suffix = "RC";
                 break;
+            default:
+                let suffix = "";
+                break;
         }
 
         return suffix;

tests/unit/Support/Version/GetPartCest.php

@@ -57,11 +57,11 @@ public function supportVersionGetPart(UnitTester $I)
         $actual   = $version->getPart(Version::VERSION_MINOR);
         $I->assertSame($expected, $actual);
 
-        $expected = $this->numberToSpecial($id[5]);
+        $expected = $this->numberToSpecial((string) $id[5]);
         $actual   = $version->getPart(Version::VERSION_SPECIAL);
         $I->assertSame($expected, $actual);
 
-        $special  = $this->numberToSpecial($id[5]);
+        $special  = $this->numberToSpecial((string) $id[6]);
         $expected = (string) (($special) ? $id[6] : 0);
         $actual   = $version->getPart(Version::VERSION_SPECIAL_NUMBER);
         $I->assertSame($expected, $actual);