Merge pull request #18906 from Ducasse/clean/lessInform

jecisc · web-flow · commit faf6a1d56ab9 · 2025-11-19T14:47:05.000+01:00
Cleaning a bit more inform:
diff --git a/src/Commander-Activators-Shortcut/CmdShortcutSetting.class.st b/src/Commander-Activators-Shortcut/CmdShortcutSetting.class.st
@@ -79,8 +79,8 @@ CmdShortcutSetting >> realValue: aShortcutActivation [
 CmdShortcutSetting >> setToDefault [
 
 	shortcutActivation := shortcutActivation revertRedefinedInstanceIfAbsent: [
-		self inform: 'Annotation not exists anymore'.
-		^self].
+		InformativeNotification signal: 'Annotation does not exist anymore'.
+		^ self ].
 
 	self updated
 ]
diff --git a/src/Debugger-Model/DebugContext.class.st b/src/Debugger-Model/DebugContext.class.st
@@ -52,7 +52,7 @@ DebugContext >> blockNotFoundDialog: aMethod with: aText [
 	message := 'Method for block not found on stack, can''t edit and continue'.
 
 	"shouldn't edit doits"
-	aMethod selector isDoIt ifTrue: [ ^ self inform: message ].
+	aMethod selector isDoIt ifTrue: [ ^ InformativeNotification signal: message ].
 
 	result := self
 		          confirm: message
@@ -78,7 +78,7 @@ DebugContext >> checkSelectorUnchanged: aSelector [
 	unchanged := aSelector == self selectedMessageName
 		or: [ self selectedMessageName isDoIt and: [ aSelector numArgs = self selectedMessageName numArgs ] ].
 	unchanged
-		ifFalse: [ self inform: 'can''t change selector' ].
+		ifFalse: [ InformativeNotification signal: 'can''t change selector' ].
 	^ unchanged
 ]
 
diff --git a/src/Debugger-Model/DebugSession.class.st b/src/Debugger-Model/DebugSession.class.st
@@ -438,7 +438,7 @@ DebugSession >> rewindContextToMethod: aMethod fromContext: aContext [
 
 	ctxt == aContext
 		ifFalse: [
-			self inform: 'Method saved, but current context unchanged\because of unwind error. Click OK to see error' withCRs ]
+			InformativeNotification signal: 'Method saved, but current context unchanged\because of unwind error. Click OK to see error' withCRs ]
 		ifTrue: [
 			interruptedProcess restartTopWith: aMethod.
 			self stepToFirstInterestingBytecodeIn: interruptedProcess ].
diff --git a/src/Debugger-Model/DebuggerEmmergencyLogger.class.st b/src/Debugger-Model/DebuggerEmmergencyLogger.class.st
@@ -34,7 +34,7 @@ DebuggerEmmergencyLogger >> logError: anError forSession: aDebugSession [
 		inContext: aDebugSession interruptedContext ]
 		on: Error
 		do: [ :err |
-			self inform: (String streamContents: [ :str |
+			InformativeNotification signal: (String streamContents: [ :str |
 					 str << 'Cannot log error:'.
 					 str space.
 					 str << anError description.
diff --git a/src/Monticello/MCNoChangesException.class.st b/src/Monticello/MCNoChangesException.class.st
@@ -11,5 +11,5 @@ Class {
 
 { #category : 'accessing' }
 MCNoChangesException >> defaultAction [
-	self inform: 'No changes'
+	InformativeNotification signal: 'No changes'
 ]
diff --git a/src/Refactoring-Core/RBInlineAllSendersRefactoring.class.st b/src/Refactoring-Core/RBInlineAllSendersRefactoring.class.st
@@ -66,7 +66,7 @@ RBInlineAllSendersRefactoring >> applicabilityPreconditions [
 { #category : 'transforming' }
 RBInlineAllSendersRefactoring >> checkInlinedMethods [
 	numberReplaced = 0
-		ifTrue: [self inform:  'Could not find any senders to inline into']
+		ifTrue: [ InformativeNotification signal:  'Could not find any senders to inline into']
 ]
 
 { #category : 'transforming' }
diff --git a/src/System-Hashing/DigitalSignatureAlgorithm.class.st b/src/System-Hashing/DigitalSignatureAlgorithm.class.st
@@ -51,10 +51,8 @@ DigitalSignatureAlgorithm class >> example [
 	msg := 'This is a test...'.
 	keys := self testKeySet.
 	sig := self sign: msg privateKey: keys first.
-	self inform: 'Signature created'.
-	(self verify: sig isSignatureOf: msg publicKey: keys last)
-		ifTrue: [self inform: 'Signature verified.']
-		ifFalse: [self error: 'ERROR! Signature verification failed']
+	self verify: sig isSignatureOf: msg publicKey: keys last
+		
 ]
 
 { #category : 'public' }
diff --git a/src/Text-Edition/TextPrintIt.extension.st b/src/Text-Edition/TextPrintIt.extension.st
@@ -5,6 +5,6 @@ TextPrintIt >> actOnClick: anEvent for: anObject in: paragraph editor: editor [
 
 	| result |
 	result := Smalltalk compiler receiver: anObject; evaluate: evalString.
-	self inform: result printString.
+	InformativeNotification signal: result printString.
 	^ true
 ]
diff --git a/src/Tool-Base/ToolShortcutsCategory.class.st b/src/Tool-Base/ToolShortcutsCategory.class.st
@@ -64,5 +64,5 @@ ToolShortcutsCategory >> saveImage [
 		shortcut: PharoShortcuts current saveImageShortcut
 		action: [
 			(Smalltalk snapshot: true andQuit: false) hasSavedSuccessfully
-				ifTrue: [ self inform: 'Image saved' ] ]
+				ifTrue: [ InformativeNotification signal: 'Image saved' ] ]
 ]
diff --git a/src/Tools/InformDebugger.class.st b/src/Tools/InformDebugger.class.st
@@ -11,5 +11,6 @@ Class {
 
 { #category : 'opening api' }
 InformDebugger class >> openOn: aDebugSession withFullView: aBool andNotification: aString [
-	self inform: (self messageToPrintFrom: aDebugSession)
+	
+	InformativeNotification signal: (self messageToPrintFrom: aDebugSession)
 ]

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,8 @@ CmdShortcutSetting >> realValue: aShortcutActivation [`
`79`	`79`	`CmdShortcutSetting >> setToDefault [`
`80`	`80`
`81`	`81`	`shortcutActivation := shortcutActivation revertRedefinedInstanceIfAbsent: [`
`82`		`- self inform: 'Annotation not exists anymore'.`
`83`		`- ^self].`
	`82`	`+ InformativeNotification signal: 'Annotation does not exist anymore'.`
	`83`	`+ ^ self ].`
`84`	`84`
`85`	`85`	`self updated`
`86`	`86`	`]`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,5 @@ Class {`
`11`	`11`
`12`	`12`	`{ #category : 'accessing' }`
`13`	`13`	`MCNoChangesException >> defaultAction [`
`14`		`- self inform: 'No changes'`
	`14`	`+ InformativeNotification signal: 'No changes'`
`15`	`15`	`]`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ RBInlineAllSendersRefactoring >> applicabilityPreconditions [`
`66`	`66`	`{ #category : 'transforming' }`
`67`	`67`	`RBInlineAllSendersRefactoring >> checkInlinedMethods [`
`68`	`68`	`numberReplaced = 0`
`69`		`- ifTrue: [self inform: 'Could not find any senders to inline into']`
	`69`	`+ ifTrue: [ InformativeNotification signal: 'Could not find any senders to inline into']`
`70`	`70`	`]`
`71`	`71`
`72`	`72`	`{ #category : 'transforming' }`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,6 @@ TextPrintIt >> actOnClick: anEvent for: anObject in: paragraph editor: editor [`
`5`	`5`
`6`	`6`	`\| result \|`
`7`	`7`	`result := Smalltalk compiler receiver: anObject; evaluate: evalString.`
`8`		`- self inform: result printString.`
	`8`	`+ InformativeNotification signal: result printString.`
`9`	`9`	`^ true`
`10`	`10`	`]`
Original file line number	Diff line number	Diff line change
`@@ -64,5 +64,5 @@ ToolShortcutsCategory >> saveImage [`
`64`	`64`	`shortcut: PharoShortcuts current saveImageShortcut`
`65`	`65`	`action: [`
`66`	`66`	`(Smalltalk snapshot: true andQuit: false) hasSavedSuccessfully`
`67`		`- ifTrue: [ self inform: 'Image saved' ] ]`
	`67`	`+ ifTrue: [ InformativeNotification signal: 'Image saved' ] ]`
`68`	`68`	`]`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,6 @@ Class {`
`11`	`11`
`12`	`12`	`{ #category : 'opening api' }`
`13`	`13`	`InformDebugger class >> openOn: aDebugSession withFullView: aBool andNotification: aString [`
`14`		`- self inform: (self messageToPrintFrom: aDebugSession)`
	`14`	`+`
	`15`	`+ InformativeNotification signal: (self messageToPrintFrom: aDebugSession)`
`15`	`16`	`]`