Skip to content

RBMoveMethodToClassTransformation is bogus #17959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ducasse opened this issue Mar 8, 2025 · 0 comments
Open

RBMoveMethodToClassTransformation is bogus #17959

Ducasse opened this issue Mar 8, 2025 · 0 comments
Assignees

Comments

@Ducasse
Copy link
Member

Ducasse commented Mar 8, 2025

privateTransform
	| oldClass newClass rbMethod originalProtocol |
	oldClass := self classModelOf: method methodClass.
	newClass := self classModelOf: class.
	rbMethod := model rbMethodClass for: newClass source: method sourceCode selector: method selector.
	originalProtocol := method protocolName.

	self generateChangesFor: (RBRemoveMethodTransformation 
		selector: method selector
		from: oldClass).
	self generateChangesFor: (RBAddMethodTransformation
		model: self model
		sourceCode: rbMethod
		in: newClass
		withProtocol: originalProtocol)

the code passes a method instead of the source code

Clearly some tests are missing.

The solution should be something like:

privateTransform
	| oldClass newClass rbMethod originalProtocol |
	oldClass := self classModelOf: method methodClass.
	newClass := self classModelOf: class.

	self generateChangesFor: (RBRemoveMethodTransformation 
		selector: method selector
		from: oldClass).
	self generateChangesFor: (RBAddMethodTransformation
		model: self model
		sourceCode: method sourceCode
		in: newClass
		withProtocol: method protocolName)
@Ducasse Ducasse self-assigned this Mar 8, 2025
@github-project-automation github-project-automation bot moved this to Current Iteration in Refactoring Engine Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Current Iteration
Development

No branches or pull requests

1 participant