Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New protocol is added even though the operation is canceled #18054

Open
DurieuxPol opened this issue Mar 28, 2025 · 2 comments · May be fixed by pharo-spec/NewTools#1082
Open

New protocol is added even though the operation is canceled #18054

DurieuxPol opened this issue Mar 28, 2025 · 2 comments · May be fixed by pharo-spec/NewTools#1082

Comments

@DurieuxPol
Copy link

When you add a protocol with the "New protocol" menu, if you start typing the name of an existing protocol and you press the Cancel button, the protocol is added anyway while it shouldn't.
This is for Pharo 13.

For example:

  • create a new class "MyClass", right click in the protocol column and select "New protocol"
Image
  • start typing the name of an existing protocol, like "sort". Notice that the first existing protocol is selected by default
Image
  • press the Cancel button. The protocol is added regardless
Image

It might be related this method StProtocolNameChooserPresenter class>>#requestProtocolNameConfiguring: and to issue #17978

@Ducasse
Copy link
Member

Ducasse commented Mar 28, 2025

Tx Pol!

@jecisc
Copy link
Member

jecisc commented Apr 2, 2025

Fix proposed here: pharo-spec/NewTools#1082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants