Skip to content

Commit cf7f28d

Browse files
committed
fix(lsp): restyle jump-to-definition picker header as a muted title, not a color chip
li.inlinemenu-header used a solid @bc-panel-bg-alt background, which read as a mismatched floating block against the menu's own near-black @dark-bc-menu-bg surface in dark theme. Drop the background entirely and style it as a plain muted title with a hairline divider (the same @dark-bc-menu-separator token this menu family's .divider rule already uses, so it stays visible against a near-black surface) - matching the minimal title treatment the code-excerpt side panel already uses, so both halves of the picker read as one cohesive surface.
1 parent 312520b commit cf7f28d

1 file changed

Lines changed: 18 additions & 10 deletions

File tree

src/styles/brackets_patterns_override.less

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -694,27 +694,35 @@ a:focus {
694694
}
695695
}
696696

697-
// Styles used for inlinemenu widget header. @bc-bg-tool-bar/@bc-inlinemenu-text used to be
698-
// identical in light and dark variants (a dark toolbar-grey chip that clashed against an
699-
// otherwise light dropdown in light theme) - use the theme-aware "muted panel" pair instead,
700-
// same tokens as this picker's own .jump-to-def-item-path, so the header reads as a subtle
701-
// section label rather than a mismatched dark badge.
697+
// Styles used for inlinemenu widget header. Previously a solid @bc-panel-bg-alt chip -
698+
// against the menu's own @bc-menu-bg/@dark-bc-menu-bg surface (white / near-black) that
699+
// read as a mismatched floating block sitting on top of the list, especially in dark theme.
700+
// Instead, keep it on the same surface as the rest of the menu (no background at all) and
701+
// read it as a plain muted title with a hairline divider separating it from the items
702+
// below. Same treatment as the code-excerpt popup's own title bar
703+
// (.jump-to-def-excerpt-title in brackets.less), so the two pieces of one picker look like
704+
// one cohesive, deliberately minimal surface instead of two.
702705
li.inlinemenu-header a {
703-
background-color: @bc-panel-bg-alt;
706+
background-color: transparent;
704707
color: @bc-text-medium;
705-
padding-bottom: 5px;
708+
padding-top: 6px;
709+
padding-bottom: 6px;
710+
// Same divider color this menu family already uses for its .divider rule above, so the
711+
// header's separator reads as an intentional, on-brand line rather than an arbitrary
712+
// one-off - and unlike a low-alpha white/black overlay, it stays visible against the
713+
// near-black @dark-bc-menu-bg surface.
714+
border-bottom: 1px solid @bc-menu-separator;
706715

707716
.dark & {
708-
background-color: @dark-bc-panel-bg-alt;
709717
color: @dark-bc-text-medium;
718+
border-bottom-color: @dark-bc-menu-separator;
710719
}
711720

712721
&:hover {
713-
background-color: @bc-panel-bg-alt;
722+
background-color: transparent;
714723
color: @bc-text-medium;
715724

716725
.dark & {
717-
background-color: @dark-bc-panel-bg-alt;
718726
color: @dark-bc-text-medium;
719727
}
720728
}

0 commit comments

Comments
 (0)