Raise when options_for_select is used as a value
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
commented
May 8, 2025
|
|
||
| def select_tag(name, *, **, &block) | ||
| output = if block | ||
| view_context.select_tag(name, capture(&block), *, **) |
There was a problem hiding this comment.
This actually differs form the official API in this case.
joeldrapper
commented
May 8, 2025
| @@ -4,5 +4,17 @@ module Phlex::Rails::Helpers::OptionsForSelect | |||
| extend Phlex::Rails::HelperMacros | |||
|
|
|||
| # [Rails Docs](https://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.html#method-i-options_for_select) | |||
| register_output_helper def options_for_select(...) = nil | |||
| def options_for_select(*args, **kwargs, &block) | |||
There was a problem hiding this comment.
Should probably do this for options_from_collection_for_select too.
willcosgrove
reviewed
May 8, 2025
Comment on lines
+3
to
+11
| class Phlex::Rails::Never < BasicObject | ||
| def initialize(&block) | ||
| @block = block | ||
| end | ||
|
|
||
| def method_missing(method_name, *, **) | ||
| @block.call(method_name, *, **) | ||
| end | ||
| end |
There was a problem hiding this comment.
You should see the PR I gave up on. It was popping things off the buffer. 🤣
The technique works but I thought it was too much to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.