fix class name for alias, upgrade phpunit config, force files launching in composer and cs-fixer

Author: JoMessina

.github/workflows/quality.yaml

@@ -13,7 +13,7 @@ jobs:
           run: |
             wget -q https://cs.symfony.com/download/php-cs-fixer-v3.phar -O php-cs-fixer
             chmod a+x php-cs-fixer
-            PHP_CS_FIXER_IGNORE_ENV=true ./php-cs-fixer fix src --dry-run
+            ./php-cs-fixer fix src --dry-run
 
   phpstan:
       runs-on: ubuntu-latest

composer.json

@@ -37,6 +37,7 @@
         "php-etl/phpspec-extension": "*"
     },
     "autoload": {
+        "files": ["src/Compiler/Builder/PropertyPathBuilder.php"],
         "psr-4": {
             "Kiboko\\Component\\FastMap\\": "src/"
         }

composer.lock

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <phpunit
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-        xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd"
+        xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd"
         backupGlobals="true"
         colors="false"
         processIsolation="false"
@@ -21,12 +21,13 @@
       <directory>functional/</directory>
     </testsuite>
   </testsuites>
-  <coverage>
+  <coverage/>
+  <php>
+    <ini name="allow_url_include" value="1"/>
+  </php>
+  <source>
     <include>
       <directory suffix=".php">src</directory>
     </include>
-  </coverage>
-  <php>
-    <ini name="allow_url_include" value="1" />
-  </php>
+  </source>
 </phpunit>

phpunit.xml

@@ -13,8 +13,7 @@
     public function __construct(
         private PropertyPath $propertyPath,
         private Node\Expr $pathNode
-    ) {
-    }
+    ) {}
 
     public function getNode(): Node
     {

src/Compiler/Builder/ArrayInitialisationPreconditionBuilder.php

@@ -16,8 +16,7 @@ public function __construct(
         private TypeMetadataInterface $metadata,
         private PropertyPath $propertyPath,
         private Node\Expr $pathNode
-    ) {
-    }
+    ) {}
 
     public function getNode(): Node
     {

src/Compiler/Builder/CompositeInitialisationPreconditionBuilder.php

@@ -9,9 +9,7 @@
 
 final readonly class ConstantValueBuilder implements Builder
 {
-    public function __construct(private mixed $value)
-    {
-    }
+    public function __construct(private mixed $value) {}
 
     public function getNode(): Node
     {

src/Compiler/Builder/ConstantValueBuilder.php

@@ -15,9 +15,7 @@
     /**
      * @param string[] $variables
      */
-    public function __construct(private ExpressionLanguage $interpreter, private Expression $expression, private array $variables = [])
-    {
-    }
+    public function __construct(private ExpressionLanguage $interpreter, private Expression $expression, private array $variables = []) {}
 
     public function getNode(): Node\Expr
     {

src/Compiler/Builder/ExpressionLanguageToPhpParserBuilder.php

@@ -15,8 +15,7 @@ public function __construct(
         private PropertyPath $propertyPath,
         private Node\Expr $pathNode,
         private ClassTypeMetadata $metadata
-    ) {
-    }
+    ) {}
 
     public function getNode(): Node
     {

src/Compiler/Builder/ObjectInitialisationPreconditionBuilder.php

@@ -4,11 +4,9 @@
 
 namespace Kiboko\Component\FastMap\Compiler\Builder;
 
-use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
-
-trigger_deprecation('php-etl/fast-map', '0.5.2', 'The "%s" class is deprecated, use "%s" instead.', 'Kiboko\\Component\\FastMap\\Compiler\\Builder\\PropertyPathBuilder', PropertyPathBuilder::class);
+trigger_deprecation('php-etl/fast-map', '0.5', 'The "%s" class is deprecated, use "%s" instead.', 'Kiboko\\Component\\FastMap\\Compiler\\Builder\\PropertyPathBuilder', \Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder::class);
 
 /*
- * @deprecated since FastMap 0.5.2, use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder instead.
+ * @deprecated since FastMap 0.5, use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder instead.
  */
-class_alias(PropertyPathBuilder::class, 'Kiboko\\Component\\FastMap\\Compiler\\Builder\\PropertyPathBuilder');
+class_alias(\Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder::class, 'Kiboko\\Component\\FastMap\\Compiler\\Builder\\PropertyPathBuilder');

src/Compiler/Builder/PropertyPathBuilder.php

@@ -4,6 +4,7 @@
 
 namespace Kiboko\Component\FastMap\Compiler\Builder;
 
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use PhpParser\Builder;
 use PhpParser\Node;
 use Symfony\Component\PropertyAccess\PropertyPath;
@@ -13,8 +14,7 @@
     public function __construct(
         private PropertyPath $propertyPath,
         private Node\Expr $pathNode
-    ) {
-    }
+    ) {}
 
     public function getNode(): Node
     {

src/Compiler/Builder/RequiredValuePreconditionBuilder.php

@@ -12,9 +12,7 @@
     /**
      * @param \PhpParser\Node\Stmt[] $stmts
      */
-    public function __construct(private Node\Expr $input, private Node\Expr $output, private array $stmts)
-    {
-    }
+    public function __construct(private Node\Expr $input, private Node\Expr $output, private array $stmts) {}
 
     public function getNode(): Node\Expr
     {

src/Compiler/Builder/ScopedCodeBuilder.php

@@ -15,8 +15,7 @@ public function __construct(
         private PropertyPathInterface $propertyPath,
         private ?string $path = null,
         private ?ClassMetadataInterface $class = null
-    ) {
-    }
+    ) {}
 
     public static function build(PropertyPathInterface $propertyPath, string $cachePath, string $fqcn): self
     {

src/Compiler/StandardCompilationContext.php

@@ -4,7 +4,7 @@
 
 namespace Kiboko\Component\FastMap\Compiler\Strategy;
 
-use Kiboko\Component\FastMap\Compiler\Builder\PropertyPathBuilder;
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use Kiboko\Contract\Mapping\CompilableMapperInterface;
 use Kiboko\Contract\Mapping\CompiledMapperInterface;
 use Kiboko\Contract\Mapping\Compiler\Strategy\StrategyInterface;

src/Compiler/Strategy/Spaghetti.php

@@ -4,7 +4,7 @@
 
 namespace Kiboko\Component\FastMap\Mapping;
 
-use Kiboko\Component\FastMap\Compiler\Builder\PropertyPathBuilder;
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use Kiboko\Contract\Mapping;
 use PhpParser\Node;
 use Symfony\Component\PropertyAccess\PropertyAccess;

src/Mapping/Field.php

@@ -4,8 +4,8 @@
 
 namespace Kiboko\Component\FastMap\Mapping\Field;
 
-use Kiboko\Component\FastMap\Compiler\Builder\PropertyPathBuilder;
 use Kiboko\Component\FastMap\Compiler\Builder\RequiredValuePreconditionBuilder;
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use Kiboko\Contract\Mapping;
 use PhpParser\BuilderFactory;
 use PhpParser\Node;

src/Mapping/Field/ConcatCopyValuesMapper.php

@@ -4,8 +4,8 @@
 
 namespace Kiboko\Component\FastMap\Mapping\Field;
 
-use Kiboko\Component\FastMap\Compiler\Builder\PropertyPathBuilder;
 use Kiboko\Component\FastMap\Compiler\Builder\RequiredValuePreconditionBuilder;
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use Kiboko\Contract\Mapping;
 use PhpParser\Node;
 use Symfony\Component\PropertyAccess\PropertyAccess;

src/Mapping/Field/CopyValueMapper.php

@@ -5,9 +5,9 @@
 namespace Kiboko\Component\FastMap\Mapping;
 
 use Kiboko\Component\FastMap\Compiler\Builder\ExpressionLanguageToPhpParserBuilder;
-use Kiboko\Component\FastMap\Compiler\Builder\PropertyPathBuilder;
 use Kiboko\Component\FastMap\Compiler\Builder\ScopedCodeBuilder;
 use Kiboko\Component\FastMap\PropertyAccess\EmptyPropertyPath;
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use Kiboko\Contract\Mapping;
 use PhpParser\Node;
 use Symfony\Component\ExpressionLanguage\Expression;
@@ -24,7 +24,7 @@ public function __construct(
         private PropertyPathInterface $outputPath,
         private readonly ExpressionLanguage $interpreter,
         private readonly Expression $inputExpression,
-        private readonly Mapping\CompilableMapperInterface&Mapping\ArrayMapperInterface $child
+        private readonly Mapping\ArrayMapperInterface&Mapping\CompilableMapperInterface $child
     ) {
         $this->accessor = PropertyAccess::createPropertyAccessor();
     }

src/Mapping/ListField.php

@@ -4,8 +4,8 @@
 
 namespace Kiboko\Component\FastMap\Mapping;
 
-use Kiboko\Component\FastMap\Compiler\Builder\PropertyPathBuilder;
 use Kiboko\Component\FastMap\PropertyAccess\EmptyPropertyPath;
+use Kiboko\Component\SatelliteToolbox\Builder\PropertyPathBuilder;
 use Kiboko\Contract\Mapping;
 use PhpParser\Node;
 use Symfony\Component\ExpressionLanguage\Expression;

src/Mapping/SingleRelation.php

@@ -9,9 +9,7 @@
 
 final readonly class PathMappingIterator implements \Iterator
 {
-    public function __construct(private PropertyPathIteratorInterface $inner, private TypeMetadataInterface $metadata)
-    {
-    }
+    public function __construct(private PropertyPathIteratorInterface $inner, private TypeMetadataInterface $metadata) {}
 
     public function current(): mixed
     {