Skip to content

Commit e6df8ab

Browse files
authored
FIX: store_retry_count shouldn't be set implicitly (#452)
It's wired that store commands would be auto-retry implicitly while the default value of store_retry_count was 2, as well as the timeout, would be 3 times in those store commands which may confuse users. IMHO, the retry should be set explicitly instead of implicitly.
1 parent 6d45715 commit e6df8ab

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: memcached.ini

+2-2
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@
130130
; This mechanism allows transparent fail-over to secondary servers when
131131
; set/increment/decrement/setMulti operations fail on the desired server in a multi-server
132132
; environment.
133-
; the default is 2
134-
;memcached.store_retry_count = 2
133+
; the default is 0
134+
;memcached.store_retry_count = 0
135135

136136
; Sets the default for consistent hashing for new connections.
137137
; (To configure consistent hashing for session connections,

Diff for: php_memcached.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ PHP_INI_BEGIN()
410410
MEMC_INI_ENTRY("compression_factor", "1.3", OnUpdateReal, compression_factor)
411411
MEMC_INI_ENTRY("compression_threshold", "2000", OnUpdateLong, compression_threshold)
412412
MEMC_INI_ENTRY("serializer", SERIALIZER_DEFAULT_NAME, OnUpdateSerializer, serializer_name)
413-
MEMC_INI_ENTRY("store_retry_count", "2", OnUpdateLong, store_retry_count)
413+
MEMC_INI_ENTRY("store_retry_count", "0", OnUpdateLong, store_retry_count)
414414

415415
MEMC_INI_BOOL ("default_consistent_hash", "0", OnUpdateBool, default_behavior.consistent_hash_enabled)
416416
MEMC_INI_BOOL ("default_binary_protocol", "0", OnUpdateBool, default_behavior.binary_protocol_enabled)

0 commit comments

Comments
 (0)