Implement frameless handlers for implode

Author: iluuu1994

Zend/zend_frameless_function.h

@@ -48,6 +48,11 @@
 		zend_wrong_parameter_type_error(arg_num, Z_EXPECTED_ARRAY, arg ## arg_num); \
 		goto flf_clean; \
 	}
+#define Z_FLF_PARAM_ARRAY_OR_NULL(arg_num, dest) \
+	if (!zend_parse_arg_array(arg ## arg_num, &dest, /* null_check */ true, /* or_object */ false)) { \
+		zend_wrong_parameter_type_error(arg_num, Z_EXPECTED_ARRAY_OR_NULL, arg ## arg_num); \
+		goto flf_clean; \
+	}
 #define Z_FLF_PARAM_BOOL(arg_num, dest) \
 	if (!zend_parse_arg_bool_ex(arg ## arg_num, &dest, /* is_null */ NULL, /* null_check */ false, arg_num, /* frameless */ true)) { \
 		zend_wrong_parameter_type_error(arg_num, Z_EXPECTED_BOOL, arg ## arg_num); \

ext/standard/basic_functions.stub.php

@@ -2332,6 +2332,8 @@ function explode(string $separator, string $string, int $limit = PHP_INT_MAX): a
 
 /**
  * @compile-time-eval
+ * @frameless-function {"arity": 1}
+ * @frameless-function {"arity": 2}
  */
 function implode(string|array $separator, ?array $array = null): string {}
 

ext/standard/basic_functions_arginfo.h

@@ -1052,6 +1052,43 @@ PHP_FUNCTION(implode)
 }
 /* }}} */
 
+ZEND_FRAMELESS_FUNCTION(implode, 1)
+{
+	zval *pieces;
+
+	/* Manual parsing for more accurate error message. */
+	if (!zend_parse_arg_array(arg1, &pieces, /* null_check */ false, /* or_object */ false)) { \
+		zend_type_error("%s(): Argument #1 ($array) must be of type array, %s given", get_active_function_name(), zend_zval_value_name(arg1));
+		goto flf_clean; \
+	}
+
+	zend_string *str = ZSTR_EMPTY_ALLOC();
+
+	php_implode(str, Z_ARR_P(pieces), return_value);
+
+flf_clean:;
+}
+
+ZEND_FRAMELESS_FUNCTION(implode, 2)
+{
+	zval str_tmp;
+	zend_string *str;
+	zval *pieces;
+
+	Z_FLF_PARAM_STR(1, str, str_tmp);
+	Z_FLF_PARAM_ARRAY_OR_NULL(2, pieces);
+
+	if (!pieces) {
+		zend_type_error("%s(): Argument #1 ($array) must be of type array, %s given", get_active_function_name(), zend_zval_value_name(arg1));
+		goto flf_clean;
+	}
+
+	php_implode(str, Z_ARR_P(pieces), return_value);
+
+flf_clean:;
+	Z_FLF_PARAM_FREE_STR(1, str_tmp);
+}
+
 #define STRTOK_TABLE(p) BG(strtok_table)[(unsigned char) *p]
 
 /* {{{ Tokenize a string */