ext/xmlwriter: applied fixers to improve test robustness

Author: NickSdot

ext/xmlwriter/tests/010.phpt

@@ -16,15 +16,15 @@ var_dump(xmlwriter_end_attribute($xw));
 try {
     xmlwriter_start_attribute($xw, "-1");
 } catch (ValueError $e) {
-    echo $e->getMessage(), "\n";
+    echo $e::class, ': ', $e->getMessage(), "\n";
 }
 
 var_dump(xmlwriter_end_attribute($xw));
 
 try {
     xmlwriter_start_attribute($xw, "\"");
 } catch (ValueError $e) {
-     echo $e->getMessage(), "\n";
+     echo $e::class, ': ', $e->getMessage(), "\n";
 }
 
 var_dump(xmlwriter_end_attribute($xw));
@@ -45,9 +45,9 @@ echo "Done\n";
 bool(true)
 bool(true)
 bool(true)
-xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, "-1" given
+ValueError: xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, "-1" given
 bool(false)
-xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, """ given
+ValueError: xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, """ given
 bool(false)
 bool(true)
 string(14) "<tag attr=""/>"

ext/xmlwriter/tests/gh21682.phpt

@@ -9,7 +9,7 @@ try {
     serialize($w);
     echo "ERROR: should have thrown\n";
 } catch (\Exception $e) {
-    echo $e::class, ": ", $e->getMessage(), PHP_EOL;
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
 }
 ?>
 --EXPECT--

ext/xmlwriter/tests/xmlwriter_open_uri_error_001.phpt

@@ -7,12 +7,12 @@ xmlwriter
 try {
     xmlwriter_open_uri('');
 } catch (ValueError $exception) {
-    echo $exception->getMessage() . "\n";
+    echo $exception::class, ': ', $exception->getMessage(), "\n";
 }
 ?>
 --CREDITS--
 Koen Kuipers koenk82@gmail.com
 Theo van der Zee
 #Test Fest Utrecht 09-05-2009
 --EXPECT--
-xmlwriter_open_uri(): Argument #1 ($uri) must not be empty
+ValueError: xmlwriter_open_uri(): Argument #1 ($uri) must not be empty

ext/xmlwriter/tests/xmlwriter_toMemory_custom_constructor_error.phpt

@@ -14,9 +14,9 @@ class CustomXMLWriter extends XMLWriter {
 try {
     CustomXMLWriter::toMemory();
 } catch (Throwable $e) {
-    echo $e->getMessage(), "\n";
+    echo $e::class, ': ', $e->getMessage(), "\n";
 }
 
 ?>
 --EXPECT--
-nope
+Error: nope

ext/xmlwriter/tests/xmlwriter_toStream_custom_constructor_error.phpt

@@ -16,9 +16,9 @@ $h = fopen("php://output", "w");
 try {
     CustomXMLWriter::toStream($h);
 } catch (Throwable $e) {
-    echo $e->getMessage(), "\n";
+    echo $e::class, ': ', $e->getMessage(), "\n";
 }
 
 ?>
 --EXPECT--
-nope
+Error: nope

ext/xmlwriter/tests/xmlwriter_toStream_open_invalidated_stream.phpt

@@ -11,9 +11,9 @@ fclose($h);
 try {
     XMLWriter::toStream($h);
 } catch (TypeError $e) {
-    echo $e->getMessage(), "\n";
+    echo $e::class, ': ', $e->getMessage(), "\n";
 }
 
 ?>
 --EXPECT--
-XMLWriter::toStream(): supplied resource is not a valid stream resource
+TypeError: XMLWriter::toStream(): supplied resource is not a valid stream resource