Implemented suggestion: moved allocation under request initialization to avoid unnecessary free call

Author: Lung-Alexandra

sapi/fuzzer/fuzzer-json.c

@@ -31,15 +31,15 @@
 #include "ext/json/php_json_parser.h"
 
 int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
-	char *data = malloc(Size+1);
-	memcpy(data, Data, Size);
-	data[Size] = '\0';
 
-	if (fuzzer_request_startup() == FAILURE) {
-        free(data);
+    if (fuzzer_request_startup() == FAILURE) {
 		return 0;
 	}
 
+    char *data = malloc(Size+1);
+    memcpy(data, Data, Size);
+    data[Size] = '\0';
+
 	for (int option = 0; option <=1; ++option) {
 		zval result;
 		php_json_parser parser;

sapi/fuzzer/fuzzer-mbregex.c

@@ -31,15 +31,15 @@
 int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
 #ifdef HAVE_MBREGEX
 	char *args[2];
-	char *data = malloc(Size+1);
-	memcpy(data, Data, Size);
-	data[Size] = '\0';
-
+    
 	if (fuzzer_request_startup() == FAILURE) {
-        free(data);
 		return 0;
 	}
 
+    char *data = malloc(Size+1);
+	memcpy(data, Data, Size);
+	data[Size] = '\0';
+
 	fuzzer_setup_dummy_frame();
 
 	args[0] = data;

sapi/fuzzer/fuzzer-unserialize.c

@@ -30,15 +30,15 @@
 #include "ext/standard/php_var.h"
 
 int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
-	unsigned char *orig_data = malloc(Size+1);
-	memcpy(orig_data, Data, Size);
-	orig_data[Size] = '\0';
 
-	if (fuzzer_request_startup() == FAILURE) {
-        free(orig_data)
+    if (fuzzer_request_startup() == FAILURE) {
 		return 0;
 	}
 
+    unsigned char *orig_data = malloc(Size+1);
+    memcpy(orig_data, Data, Size);
+    orig_data[Size] = '\0';
+
 	fuzzer_setup_dummy_frame();
 
 	{

sapi/fuzzer/fuzzer-unserializehash.c

@@ -34,16 +34,15 @@ int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t FullSize) {
 	}
 	++Start;
 
-	size_t Size = (Data + FullSize) - Start;
-	unsigned char *orig_data = malloc(Size+1);
-	memcpy(orig_data, Start, Size);
-	orig_data[Size] = '\0';
-
 	if (fuzzer_request_startup() == FAILURE) {
-        free(orig_data);
 		return 0;
 	}
 
+    size_t Size = (Data + FullSize) - Start;
+    unsigned char *orig_data = malloc(Size+1);
+    memcpy(orig_data, Start, Size);
+    orig_data[Size] = '\0';
+
 	fuzzer_setup_dummy_frame();
 
 	{