allow to build with system liburiparser #18886
Conversation
remicollet
force-pushed
the
issue-liburiparser
branch
from
a6fbc68 to
59a21c3
Compare
| $URIPARSER_DIR/src/UriRecompose.c $URIPARSER_DIR/src/UriResolve.c $URIPARSER_DIR/src/UriShorten.c" | ||
| URI_CFLAGS="-DURI_STATIC_BUILD" | ||
| else | ||
| PKG_CHECK_MODULES([LIBURIPARSER], [liburiparser >= 0.9.8]) |
There was a problem hiding this comment.
So will have to be 0.9.9 later (in PR #18836)
There was a problem hiding this comment.
Perhaps also an even later version, since that PR also is not fully implementing the RFC. The "withers" to update an URI are missing and might also require some upstream changes.
That's likely because the library is not actually used yet. See #18836. The current git HEAD of uriparser contains some fixes contributed by Máté. |
:( BTW, I think we should allow building with system libraries, and bundled libraries should be exceptional It seems a new version (0.9.9) will required (and we should encourage upstream to release it with needed patches) |
Yes.
Yes, once all the necessary changes are included upstream. |
Yes, 0.9.9 will likely be the next release for sure according to this review suggestion: uriparser/uriparser#230 (comment) |
remicollet
force-pushed
the
issue-liburiparser
branch
from
59a21c3 to
2e6ae0e
Compare
To avoid another bundled library
Test suite with version 0.9.8 passes
Notice: It seems the bundled version is not really 0.9.8, but rather a git snapshot
New build option
--with-external-uriparser(as we already have--with-external-gdand--with-external-libcrypt)Use bundled sources by default.