Merge pull request #22 from ksimka/patch-1

Fix getMethod

Author: mvriel

src/phpDocumentor/Reflection/InterfaceReflector.php

@@ -48,7 +48,7 @@ public function parseSubElements()
                     }
                     break;
                 case 'PHPParser_Node_Stmt_ClassMethod':
-                    $this->methods[] = new ClassReflector\MethodReflector(
+                    $this->methods[strtolower($stmt->name)] = new ClassReflector\MethodReflector(
                         $stmt,
                         $this->context
                     );
@@ -107,10 +107,12 @@ public function getMethods()
 
     /**
      * @param string $name the method name
-     * @return ClassReflector\MethodReflector
+     * @return ClassReflector\MethodReflector|null
      */
     public function getMethod($name)
     {
-        return $this->methods[$name];
+        $name = strtolower($name);
+
+        return isset($this->methods[$name]) ? $this->methods[$name] : null;
     }
 }

tests/unit/phpDocumentor/Reflection/ClassReflectorTest.php

@@ -149,4 +149,33 @@ public function testGetInterfaces()
 
         $this->assertEquals(array('\dummy'), $class_reflector->getInterfaces());
     }
+
+    /**
+     * Tests the getMethod method
+     *
+     * @covers \phpDocumentor\Reflection\ClassReflector::getMethod
+     *
+     * @return void
+     */
+    public function testGetMethod()
+    {
+        $node = new NodeStmtMock();
+        $node->stmts = array(new \PHPParser_Node_Stmt_ClassMethod('someMethod'));
+        $class_reflector = new ClassReflectorMock(
+            $node,
+            new Context()
+        );
+
+        // Before parseSubElements
+        $this->assertNull($class_reflector->getMethod('someMethod'));
+
+        $class_reflector->parseSubElements();
+
+        // After parseSubElements
+        $this->assertInstanceOf(
+            '\phpDocumentor\Reflection\ClassReflector\MethodReflector',
+            $class_reflector->getMethod('someMethod')
+        );
+        $this->assertNull($class_reflector->getMethod('someOtherMethod'));
+    }
 }