Skip to content

Commit b5985f6

Browse files
committed
Change function name to Countsubscribers, fix the tests
Signed-off-by: Xheni Myrtaj <[email protected]>
1 parent ba0c892 commit b5985f6

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

src/Controller/ListController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function getMembersAction(Request $request, SubscriberList $list): View
106106
*
107107
* @return View
108108
*/
109-
public function getCountAction(Request $request, SubscriberList $list): View
109+
public function getCountsubscribersAction(Request $request, SubscriberList $list): View
110110
{
111111
$this->requireAuthentication($request);
112112

tests/Integration/Controller/ListControllerTest.php

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -335,20 +335,20 @@ public function getListMembersWithCurrentSessionKeyForExistingListWithSubscriber
335335
/**
336336
* @test
337337
*/
338-
public function getListCountForExistingListWithoutSessionKeyReturnsForbiddenStatus()
338+
public function getListCountsubscribersForExistingListWithoutSessionKeyReturnsForbiddenStatus()
339339
{
340340
$this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
341341
$this->applyDatabaseChanges();
342342

343-
$this->client->request('get', '/api/v2/lists/1/count');
343+
$this->client->request('get', '/api/v2/lists/1/countsubscribers');
344344

345345
$this->assertHttpForbidden();
346346
}
347347

348348
/**
349349
* @test
350350
*/
351-
public function getListCountForExistingListWithExpiredSessionKeyReturnsForbiddenStatus()
351+
public function getListCountsubscribersForExistingListWithExpiredSessionKeyReturnsForbiddenStatus()
352352
{
353353
$this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
354354
$this->getDataSet()->addTable(static::ADMINISTRATOR_TABLE_NAME, __DIR__ . '/Fixtures/Administrator.csv');
@@ -357,7 +357,7 @@ public function getListCountForExistingListWithExpiredSessionKeyReturnsForbidden
357357

358358
$this->client->request(
359359
'get',
360-
'/api/v2/lists/1/count',
360+
'/api/v2/lists/1/countsubscribers',
361361
[],
362362
[],
363363
['PHP_AUTH_USER' => 'unused', 'PHP_AUTH_PW' => 'cfdf64eecbbf336628b0f3071adba763']
@@ -369,45 +369,45 @@ public function getListCountForExistingListWithExpiredSessionKeyReturnsForbidden
369369
/**
370370
* @test
371371
*/
372-
public function getListCountWithCurrentSessionKeyForExistingListReturnsOkayStatus()
372+
public function getListCountsubscribersWithCurrentSessionKeyForExistingListReturnsOkayStatus()
373373
{
374374
$this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
375375
$this->applyDatabaseChanges();
376376

377-
$this->authenticatedJsonRequest('get', '/api/v2/lists/1/count');
377+
$this->authenticatedJsonRequest('get', '/api/v2/lists/1/countsubscribers');
378378

379379
$this->assertHttpOkay();
380380
}
381381

382382
/**
383383
* @test
384384
*/
385-
public function getListCountWithCurrentSessionKeyForExistingListWithSubscribersReturnsSubscribersCount()
385+
public function getListCountsubscribersWithCurrentSessionKeyForExistingListWithNoSubscribersReturnsZero()
386386
{
387387
$this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
388388
$this->getDataSet()->addTable(static::SUBSCRIBER_TABLE_NAME, __DIR__ . '/Fixtures/Subscriber.csv');
389389
$this->getDataSet()->addTable(static::SUBSCRIPTION_TABLE_NAME, __DIR__ . '/Fixtures/Subscription.csv');
390390
$this->applyDatabaseChanges();
391391

392-
$this->authenticatedJsonRequest('get', '/api/v2/lists/2/count');
392+
$this->authenticatedJsonRequest('get', '/api/v2/lists/3/countsubscribers');
393393
$response = $this->getResponseContentAsInt();
394-
395-
static::assertSame(1, $response);
394+
395+
static::assertSame(0, $response);
396396
}
397397

398398
/**
399399
* @test
400400
*/
401-
public function getListCountWithCurrentSessionKeyForExistingListWithNoSubscribersReturnsZero()
401+
public function getListCountsubscribersWithCurrentSessionKeyForExistingListWithSubscribersReturnsSubscribersCount()
402402
{
403403
$this->getDataSet()->addTable(static::LISTS_TABLE_NAME, __DIR__ . '/Fixtures/SubscriberList.csv');
404404
$this->getDataSet()->addTable(static::SUBSCRIBER_TABLE_NAME, __DIR__ . '/Fixtures/Subscriber.csv');
405405
$this->getDataSet()->addTable(static::SUBSCRIPTION_TABLE_NAME, __DIR__ . '/Fixtures/Subscription.csv');
406406
$this->applyDatabaseChanges();
407407

408-
$this->authenticatedJsonRequest('get', '/api/v2/lists/3/count');
408+
$this->authenticatedJsonRequest('get', '/api/v2/lists/2/countsubscribers');
409409
$response = $this->getResponseContentAsInt();
410410

411-
static::assertSame(0, $response);
411+
static::assertSame(1, $response);
412412
}
413413
}

0 commit comments

Comments
 (0)