Skip to content

Commit 77ebb85

Browse files
committed
Make rules.neon safe to use by everyone
1 parent 1484924 commit 77ebb85

File tree

5 files changed

+6
-15
lines changed

5 files changed

+6
-15
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
},
1212
"phpstan": {
1313
"includes": [
14-
"extension.neon"
14+
"extension.neon",
15+
"rules.neon"
1516
]
1617
}
1718
},

src/Rules/Doctrine/ORM/DqlRule.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use PhpParser\Node;
66
use PHPStan\Analyser\Scope;
77
use PHPStan\Rules\Rule;
8-
use PHPStan\ShouldNotHappenException;
98
use PHPStan\Type\Doctrine\ObjectMetadataResolver;
109
use PHPStan\Type\ObjectType;
1110
use PHPStan\Type\TypeUtils;
@@ -59,7 +58,7 @@ public function processNode(Node $node, Scope $scope): array
5958

6059
$objectManager = $this->objectMetadataResolver->getObjectManager();
6160
if ($objectManager === null) {
62-
throw new ShouldNotHappenException('Please provide the "objectManagerLoader" setting for the DQL validation.');
61+
return [];
6362
}
6463
if (!$objectManager instanceof $entityManagerInterface) {
6564
return [];

src/Rules/Doctrine/ORM/MagicRepositoryMethodCallRule.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,7 @@ public function processNode(Node $node, Scope $scope): array
7878

7979
$objectManager = $this->objectMetadataResolver->getObjectManager();
8080
if ($objectManager === null) {
81-
throw new \PHPStan\ShouldNotHappenException(sprintf(
82-
'Please provide the "objectManagerLoader" setting for magic repository %s::%s() method validation.',
83-
$calledOnType->getClassName(),
84-
$methodName
85-
));
81+
return [];
8682
}
8783

8884
$fieldName = $this->classify($methodFieldName);

src/Rules/Doctrine/ORM/QueryBuilderDqlRule.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use PhpParser\Node\Expr\MethodCall;
77
use PHPStan\Analyser\Scope;
88
use PHPStan\Rules\Rule;
9-
use PHPStan\ShouldNotHappenException;
109
use PHPStan\Type\Doctrine\DoctrineTypeUtils;
1110
use PHPStan\Type\Doctrine\ObjectMetadataResolver;
1211
use PHPStan\Type\ObjectType;
@@ -82,7 +81,7 @@ public function processNode(Node $node, Scope $scope): array
8281

8382
$objectManager = $this->objectMetadataResolver->getObjectManager();
8483
if ($objectManager === null) {
85-
throw new ShouldNotHappenException('Please provide the "objectManagerLoader" setting for the DQL validation.');
84+
return [];
8685
}
8786

8887
$entityManagerInterface = 'Doctrine\ORM\EntityManagerInterface';

src/Rules/Doctrine/ORM/RepositoryMethodCallRule.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ public function processNode(Node $node, Scope $scope): array
6565

6666
$objectManager = $this->objectMetadataResolver->getObjectManager();
6767
if ($objectManager === null) {
68-
throw new \PHPStan\ShouldNotHappenException(sprintf(
69-
'Please provide the "objectManagerLoader" setting for magic repository %s::%s() method validation.',
70-
$calledOnType->getClassName(),
71-
$methodName
72-
));
68+
return [];
7369
}
7470

7571
$entityClass = $calledOnType->getEntityClass();

0 commit comments

Comments
 (0)