[BE] Check @phpstan-pure

Author: ondrejmirtes

changelog-2.0.md

@@ -19,6 +19,12 @@ Major new features 🚀
 * Always report always true conditions, except for last elseif and match arm (https://github.com/phpstan/phpstan-src/commit/565fb0f6da9cdc58e8686598015561a848693972)
 * Remove "unreachable branches" rules: UnreachableIfBranchesRule, UnreachableTernaryElseBranchRule, unreachable arm error in MatchExpressionRule
     * Because "always true" is always reported, these are no longer needed
+* Checking truthiness of `@phpstan-pure` above functions and methods
+* Check `new`/function call/method call/static method call on a separate line without any side effects even without `@phpstan-pure` PHPDoc tag on the declaration side
+    * https://github.com/phpstan/phpstan-src/commit/281a87d1ab61809076ecfa6dfc2cc86e3babe235
+    * [#3020](https://github.com/phpstan/phpstan-src/pull/3020), thanks @staabm!
+    * [#3022](https://github.com/phpstan/phpstan-src/pull/3022), thanks @staabm!
+    * [#3023](https://github.com/phpstan/phpstan-src/pull/3023), thanks @staabm!
 * LogicalXorConstantConditionRule (level 4) (https://github.com/phpstan/phpstan-src/commit/3a12724fd636b1bcf36c22b36e8f765d97150895, https://github.com/phpstan/phpstan-src/commit/3b011f6524254dad0f16840fdcfdbe7421548617), #7539
 * Check that each trait is used and analysed at least once (level 4) (https://github.com/phpstan/phpstan-src/commit/c4d05276fb8605d6ac20acbe1cc5df31cd6c10b0)
 * Check preg_quote delimiter sanity (level 0) ([#3252](https://github.com/phpstan/phpstan-src/pull/3252)), #11338, thanks @staabm!
@@ -78,12 +84,6 @@ Bleeding edge (TODO move to other sections)
 * Report unused results of `&&` and `||` (https://github.com/phpstan/phpstan-src/commit/cf2c8bbd9ebd2ebe300dbd310e136ad603d7def3)
 * Add option `reportAnyTypeWideningInVarTag` ([#2840](https://github.com/phpstan/phpstan-src/pull/2840)), thanks @janedbal!
 * Fix checking generic `mixed` type based on config ([#2885](https://github.com/phpstan/phpstan-src/pull/2885)), thanks @schlndh!
-* Checking truthiness of `@phpstan-pure` above functions and methods
-* Check `new`/function call/method call/static method call on a separate line without any side effects even without `@phpstan-pure` PHPDoc tag on the declaration side
-    * https://github.com/phpstan/phpstan-src/commit/281a87d1ab61809076ecfa6dfc2cc86e3babe235
-    * [#3020](https://github.com/phpstan/phpstan-src/pull/3020), thanks @staabm!
-    * [#3022](https://github.com/phpstan/phpstan-src/pull/3022), thanks @staabm!
-    * [#3023](https://github.com/phpstan/phpstan-src/pull/3023), thanks @staabm!
 * CallToConstructorStatementWithoutSideEffectsRule - report class with no constructor (https://github.com/phpstan/phpstan-src/commit/b116d25a6e4ba6c09f59af6569d9e6f6fd20aff4)
 * Check `@param-immediately-invoked-callable` and `@param-later-invoked-callable` (https://github.com/phpstan/phpstan-src/commit/580a6add422f4e34191df9e7a77ba1655e914bda), #10932
 

conf/bleedingEdge.neon

@@ -3,5 +3,3 @@ parameters:
 		bleedingEdge: true
 		skipCheckGenericClasses!: []
 		stricterFunctionMap: true
-
-		pure: true

conf/config.level2.neon

@@ -63,16 +63,14 @@ rules:
 	- PHPStan\Rules\PhpDoc\RequireImplementsDefinitionClassRule
 	- PHPStan\Rules\PhpDoc\RequireExtendsDefinitionClassRule
 	- PHPStan\Rules\PhpDoc\RequireExtendsDefinitionTraitRule
+	- PHPStan\Rules\Pure\PureFunctionRule
+	- PHPStan\Rules\Pure\PureMethodRule
 
 conditionalTags:
 	PHPStan\Rules\Methods\IllegalConstructorMethodCallRule:
 		phpstan.rules.rule: %featureToggles.illegalConstructorMethodCall%
 	PHPStan\Rules\Methods\IllegalConstructorStaticCallRule:
 		phpstan.rules.rule: %featureToggles.illegalConstructorMethodCall%
-	PHPStan\Rules\Pure\PureFunctionRule:
-		phpstan.rules.rule: %featureToggles.pure%
-	PHPStan\Rules\Pure\PureMethodRule:
-		phpstan.rules.rule: %featureToggles.pure%
 
 services:
 	-
@@ -118,8 +116,3 @@ services:
 		class: PHPStan\Rules\PhpDoc\InvalidPHPStanDocTagRule
 		tags:
 			- phpstan.rules.rule
-	-
-		class: PHPStan\Rules\Pure\PureFunctionRule
-
-	-
-		class: PHPStan\Rules\Pure\PureMethodRule

conf/config.level4.neon

@@ -3,12 +3,17 @@ includes:
 
 rules:
 	- PHPStan\Rules\Arrays\DeadForeachRule
+	- PHPStan\Rules\DeadCode\CallToConstructorStatementWithoutImpurePointsRule
+	- PHPStan\Rules\DeadCode\CallToFunctionStatementWithoutImpurePointsRule
+	- PHPStan\Rules\DeadCode\CallToMethodStatementWithoutImpurePointsRule
+	- PHPStan\Rules\DeadCode\CallToStaticMethodStatementWithoutImpurePointsRule
 	- PHPStan\Rules\DeadCode\NoopRule
 	- PHPStan\Rules\DeadCode\UnreachableStatementRule
 	- PHPStan\Rules\DeadCode\UnusedPrivateConstantRule
 	- PHPStan\Rules\DeadCode\UnusedPrivateMethodRule
 	- PHPStan\Rules\Exceptions\OverwrittenExitPointByFinallyRule
 	- PHPStan\Rules\Functions\CallToFunctionStatementWithoutSideEffectsRule
+	- PHPStan\Rules\Methods\CallToConstructorStatementWithoutSideEffectsRule
 	- PHPStan\Rules\Methods\CallToMethodStatementWithoutSideEffectsRule
 	- PHPStan\Rules\Methods\CallToStaticMethodStatementWithoutSideEffectsRule
 	- PHPStan\Rules\Methods\NullsafeMethodCallRule
@@ -20,30 +25,6 @@ rules:
 	- PHPStan\Rules\TooWideTypehints\TooWidePropertyTypeRule
 	- PHPStan\Rules\Traits\NotAnalysedTraitRule
 
-conditionalTags:
-	PHPStan\Rules\DeadCode\CallToConstructorStatementWithoutImpurePointsRule:
-		phpstan.rules.rule: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\PossiblyPureNewCollector:
-		phpstan.collector: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\ConstructorWithoutImpurePointsCollector:
-		phpstan.collector: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\CallToFunctionStatementWithoutImpurePointsRule:
-		phpstan.rules.rule: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\PossiblyPureFuncCallCollector:
-		phpstan.collector: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\FunctionWithoutImpurePointsCollector:
-		phpstan.collector: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\CallToMethodStatementWithoutImpurePointsRule:
-		phpstan.rules.rule: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\PossiblyPureMethodCallCollector:
-		phpstan.collector: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\MethodWithoutImpurePointsCollector:
-		phpstan.collector: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\CallToStaticMethodStatementWithoutImpurePointsRule:
-		phpstan.rules.rule: %featureToggles.pure%
-	PHPStan\Rules\DeadCode\PossiblyPureStaticCallCollector:
-		phpstan.collector: %featureToggles.pure%
-
 parameters:
 	checkAdvancedIsset: true
 
@@ -84,38 +65,40 @@ services:
 		tags:
 			- phpstan.rules.rule
 
-	-
-		class: PHPStan\Rules\DeadCode\CallToConstructorStatementWithoutImpurePointsRule
-
 	-
 		class: PHPStan\Rules\DeadCode\ConstructorWithoutImpurePointsCollector
+		tags:
+			- phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\PossiblyPureNewCollector
-
-	-
-		class: PHPStan\Rules\DeadCode\CallToFunctionStatementWithoutImpurePointsRule
+		tags:
+			- phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\FunctionWithoutImpurePointsCollector
+		tags:
+			 - phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\PossiblyPureFuncCallCollector
-
-	-
-		class: PHPStan\Rules\DeadCode\CallToMethodStatementWithoutImpurePointsRule
+		tags:
+			 - phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\MethodWithoutImpurePointsCollector
+		tags:
+			 - phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\PossiblyPureMethodCallCollector
-
-	-
-		class: PHPStan\Rules\DeadCode\CallToStaticMethodStatementWithoutImpurePointsRule
+		tags:
+			 - phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\PossiblyPureStaticCallCollector
+		tags:
+			 - phpstan.collector
 
 	-
 		class: PHPStan\Rules\DeadCode\UnusedPrivatePropertyRule
@@ -245,13 +228,6 @@ services:
 		tags:
 			- phpstan.rules.rule
 
-	-
-		class: PHPStan\Rules\Methods\CallToConstructorStatementWithoutSideEffectsRule
-		arguments:
-			reportNoConstructor: %featureToggles.pure%
-		tags:
-			- phpstan.rules.rule
-
 	-
 		class: PHPStan\Rules\TooWideTypehints\TooWideMethodReturnTypehintRule
 		arguments:

conf/config.neon

@@ -25,7 +25,6 @@ parameters:
 		skipCheckGenericClasses: []
 		illegalConstructorMethodCall: false
 		stricterFunctionMap: false
-		pure: false
 	fileExtensions:
 		- php
 	checkAdvancedIsset: false

conf/parametersSchema.neon

@@ -31,7 +31,6 @@ parametersSchema:
 		skipCheckGenericClasses: listOf(string()),
 		illegalConstructorMethodCall: bool(),
 		stricterFunctionMap: bool()
-		pure: bool()
 	])
 	fileExtensions: listOf(string())
 	checkAdvancedIsset: bool()

src/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRule.php

@@ -19,7 +19,6 @@ final class CallToConstructorStatementWithoutSideEffectsRule implements Rule
 
 	public function __construct(
 		private ReflectionProvider $reflectionProvider,
-		private bool $reportNoConstructor,
 	)
 	{
 	}
@@ -47,16 +46,12 @@ public function processNode(Node $node, Scope $scope): array
 
 		$classReflection = $this->reflectionProvider->getClass($className);
 		if (!$classReflection->hasConstructor()) {
-			if ($this->reportNoConstructor) {
-				return [
-					RuleErrorBuilder::message(sprintf(
-						'Call to new %s() on a separate line has no effect.',
-						$classReflection->getDisplayName(),
-					))->identifier('new.resultUnused')->build(),
-				];
-			}
-
-			return [];
+			return [
+				RuleErrorBuilder::message(sprintf(
+					'Call to new %s() on a separate line has no effect.',
+					$classReflection->getDisplayName(),
+				))->identifier('new.resultUnused')->build(),
+			];
 		}
 
 		$constructor = $classReflection->getConstructor();

tests/PHPStan/Rules/Methods/CallToConstructorStatementWithoutSideEffectsRuleTest.php

@@ -13,7 +13,7 @@ class CallToConstructorStatementWithoutSideEffectsRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new CallToConstructorStatementWithoutSideEffectsRule($this->createReflectionProvider(), true);
+		return new CallToConstructorStatementWithoutSideEffectsRule($this->createReflectionProvider());
 	}
 
 	public function testRule(): void