Skip to content

Commit 8170105

Browse files
committed
Fixed USE_X11 flag behavior
1 parent c1acdbe commit 8170105

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

CMakeLists.txt

+5-3
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,8 @@ if(UNIX AND NOT (APPLE OR HAIKU))
199199
if(USE_X11)
200200
add_definitions( -DHAVE_X11 )
201201
message(STATUS "X11 features support - ENABLED")
202+
elseif(NOT LIMIT_X11_USAGE)
203+
set(USE_XSS OFF)
202204
endif()
203205
if(LIMIT_X11_USAGE)
204206
add_definitions( -DLIMIT_X11_USAGE )
@@ -228,9 +230,9 @@ endif()
228230
# Detect NetBSD and handle library path accordingly
229231
STRING (REGEX MATCH "NetBSD" PROJECT_OS_NETBSD ${CMAKE_SYSTEM_NAME})
230232
if(PROJECT_OS_NETBSD)
231-
message(STATUS "NetBSD detected")
232-
set(CMAKE_C_FLAGS "-Wl,-rpath,/usr/X11R7/lib -Wl,-rpath,/usr/pkg/lib -Wl,-rpath,/usr/pkg/qt5/lib")
233-
set(CMAKE_CXX_FLAGS "-Wl,-rpath,/usr/X11R7/lib -Wl,-rpath,/usr/pkg/lib -Wl,-rpath,/usr/pkg/qt5/lib")
233+
message(STATUS "NetBSD detected")
234+
set(CMAKE_C_FLAGS "-Wl,-rpath,/usr/X11R7/lib -Wl,-rpath,/usr/pkg/lib -Wl,-rpath,/usr/pkg/qt5/lib")
235+
set(CMAKE_CXX_FLAGS "-Wl,-rpath,/usr/X11R7/lib -Wl,-rpath,/usr/pkg/lib -Wl,-rpath,/usr/pkg/qt5/lib")
234236
endif()
235237

236238
# Qt dependencies make building very slow

src/CMakeLists.txt

+11-9
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,19 @@ if(USE_KEYCHAIN)
4949
endif()
5050

5151
if(LINUX)
52-
find_package(Qt5 COMPONENTS X11Extras REQUIRED)
5352
if(USE_DBUS)
5453
find_package(Qt5 COMPONENTS DBus REQUIRED)
5554
endif()
56-
find_package(XCB REQUIRED)
57-
set(EXTRA_LIBS
58-
${XCB_LIBRARY}
59-
)
60-
include_directories(${LIBXCB_INCLUDE_DIR})
61-
add_definitions(${LIBXCB_DEFINITIONS})
55+
if(USE_X11 OR LIMIT_X11_USAGE)
56+
find_package(Qt5 COMPONENTS X11Extras REQUIRED)
57+
find_package(XCB REQUIRED)
58+
set(EXTRA_LIBS
59+
${XCB_LIBRARY}
60+
)
61+
include_directories(${LIBXCB_INCLUDE_DIR})
62+
add_definitions(${LIBXCB_DEFINITIONS})
63+
list(APPEND QT_LIBRARIES Qt5::X11Extras ${LIBXCB_LIBRARIES})
64+
endif()
6265
endif()
6366

6467
if(APPLE)
@@ -80,7 +83,6 @@ endif()
8083
set(QT_LIBRARIES Qt5::Widgets Qt5::Core Qt5::Network Qt5::Xml ${WEBKIT_LIBS} Qt5::Concurrent Qt5::Multimedia Qt5::Svg Qt5::Sql ${KEYCHAIN_LIBS})
8184

8285
if(LINUX)
83-
list(APPEND QT_LIBRARIES Qt5::X11Extras ${LIBXCB_LIBRARIES})
8486
if(USE_DBUS)
8587
list(APPEND QT_LIBRARIES Qt5::DBus)
8688
endif()
@@ -109,7 +111,7 @@ else()
109111
endif()
110112
endif()
111113

112-
if(LINUX)
114+
if(LINUX AND (USE_X11 OR LIMIT_X11_USAGE))
113115
find_package(X11 REQUIRED)
114116
include_directories(${X11_INCLUDE_DIR})
115117
endif()

0 commit comments

Comments
 (0)