Skip to content

Commit 77b2254

Browse files
committed
Address comment from gemini
Signed-off-by: JaySon-Huang <[email protected]>
1 parent 8be4341 commit 77b2254

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

tiflash/create-tiflash-replicas.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ Before TiFlash replicas are added, each TiKV instance performs a full table scan
160160
> tiup ctl:v8.5.0 pd -u http://192.168.1.4:2379 store limit all engine tiflash 60 add-peer
161161
> ```
162162

163-
If there are already a significant number of Regions exist in the old TiFlash nodes in the cluster, and these Regions need to be rebalanced from the old TiFlash nodes to the new ones, the `remove-peer` restriction must also be adjusted accordingly.
163+
If a significant number of Regions already exist in the old TiFlash nodes and need rebalancing to the new nodes, adjust the `remove-peer` restriction accordingly.
164164

165165
```shell
166166
tiup ctl:v<CLUSTER_VERSION> pd -u http://<PD_ADDRESS>:2379 store limit all engine tiflash 60 remove-peer

tiflash/tiflash-configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ Note that the following parameters only take effect in TiFlash logs and TiFlash
361361

362362
- The memory usage limit for the generated intermediate data in all queries.
363363
- When the value is an integer, the unit is byte. For example, `34359738368` means 32 GiB of memory limit, and `0` means no limit.
364-
- You can set the value to a floating-point number in the range of `[0.0, 1.0)` since v6.6.0. A floating-point number means the ratio of the allowed memory usage to the total memory of the node. For example, `0.8` means 80% of the total memory, and `0.0` means no limit.
364+
- Since v6.6.0, you can set the value to a floating-point number in the range of `[0.0, 1.0)`. This number represents the ratio of allowed memory usage to the total node memory. For example, `0.8` means 80% of the total memory, and `0.0` means no limit.
365365
- When the queries attempt to consume memory that exceeds this limit, the queries are terminated and an error is reported.
366366
- Default value: `0.8`, which means 80% of the total memory.
367367

tiflash/tiflash-overview.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ TiFlash provides the columnar storage, with a layer of coprocessors efficiently
2626

2727
TiFlash conducts real-time replication of data in the TiKV nodes at a low cost that does not block writes in TiKV. Meanwhile, it provides the same read consistency as in TiKV and ensures that the latest data is read. The Region replica in TiFlash is logically identical to those in TiKV, and is split and merged along with the Leader replica in TiKV at the same time.
2828

29-
To deploy TiFlash under the Linux AMD64 architecture, the CPU must support the AVX2 instruction set. Ensure that `grep avx2 /proc/cpuinfo` has output. To deploy TiFlash under the Linux ARM64 architecture, the CPU must support the ARMv8 instruction set architecture. Ensure that `grep 'crc32' /proc/cpuinfo | grep 'asimd'` has output. By using the instruction set extensions, TiFlash's vectorization engine can deliver better performance.
29+
Deploying TiFlash on Linux AMD64 architecture requires a CPU that supports the AVX2 instruction set. Verify this by ensuring `grep avx2 /proc/cpuinfo` produces output. For Linux ARM64 architecture, the CPU must support the ARMv8 instruction set architecture. Verify this by ensuring `grep 'crc32' /proc/cpuinfo | grep 'asimd'` produces output. By using the instruction set extensions, TiFlash's vectorization engine can deliver better performance.
3030

3131
<CustomContent platform="tidb">
3232

tiflash/troubleshoot-tiflash.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ The issue might occur due to different reasons. It is recommended that you troub
3232
3333
3. Use the PD Control tool to check whether there is any TiFlash instance that failed to go offline on the node (same IP and Port) and force the instance(s) to go offline. For detailed steps, refer to [Scale in a TiFlash cluster](/scale-tidb-using-tiup.md#scale-in-a-tiflash-cluster).
3434
35-
4. Check whether the system CPU supports vector extension instruction sets
35+
4. Check whether the CPU supports SIMD instructions
3636
37-
Starting from v6.3, to deploy TiFlash under the Linux AMD64 architecture, the CPU must support the AVX2 instruction set. Ensure that `grep avx2 /proc/cpuinfo` has output. To deploy TiFlash under the Linux ARM64 architecture, the CPU must support the ARMv8 instruction set architecture. Ensure that `grep 'crc32' /proc/cpuinfo | grep 'asimd'` has output.
37+
Starting with v6.3, deploying TiFlash on Linux AMD64 architecture requires a CPU that supports the AVX2 instruction set. Verify this by ensuring `grep avx2 /proc/cpuinfo` produces output. For Linux ARM64 architecture, the CPU must support the ARMv8 instruction set architecture. Verify this by ensuring `grep 'crc32' /proc/cpuinfo | grep 'asimd'` produces output.
3838
3939
If deploying on a virtual machine, change the virtual machine's CPU architecture to "Haswell".
4040

0 commit comments

Comments
 (0)