docs: document column-level privileges (v8.5)#22574
docs: document column-level privileges (v8.5)#22574hfxsd wants to merge 12 commits intopingcap:feature/preview-v8.5.6from
Conversation
hfxsd
added
the
translation/from-docs-cn
ti-chi-bot
bot
added
contribution
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to update the TiDB v8.5 documentation to incorporate comprehensive information regarding column-level privileges. The changes introduce a new dedicated Chinese user guide for this feature and ensure that existing documentation, including the table of contents, privilege management guides, and MySQL compatibility notes, accurately reflect the new functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to add documentation for column-level privileges in TiDB v8.5. However, the only change submitted for review is the addition of temp.md, a file that appears to be a temporary placeholder. This file does not align with the stated goals of the pull request. My review feedback recommends removing this file to ensure the pull request only contains relevant documentation changes.
I am having trouble creating individual review comments. Click here to see my feedback.
temp.md (1)
This file appears to be a temporary test file that may have been accidentally included in the pull request. Its name and content (This is a test file.) are not related to the PR's goal of documenting column-level privileges. It's recommended to remove this file from the pull request to keep the commit history clean and focused on the intended documentation.
Synced from: pingcap/docs-cn#21437 Target PR: pingcap#22574 AI Provider: gemini Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
size/L
|
/retest |
|
/retest |
Update docs to reflect implemented privilege visibility in INFORMATION_SCHEMA and mysql system tables. - Mark COLUMN_PRIVILEGES, SCHEMA_PRIVILEGES, and TABLE_PRIVILEGES as summarizing privilege information visible to the current user (information-schema.md). - Remove an obsolete link and clarify viewing column-level privileges via INFORMATION_SCHEMA.COLUMN_PRIVILEGES (column-privilege-management.md). - Note that mysql.columns_priv is supported starting in v8.5.6 (privilege-management.md). These changes align the documentation with implemented behavior for column-, schema-, and table-level privilege reporting.
|
@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: Grace Cai <qqzczy@126.com>
hfxsd
added
lgtm
and removed
contribution
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
hfxsd
added
the
do-not-merge/hold
Co-authored-by: Grace Cai <qqzczy@126.com>
hfxsd
removed
the
do-not-merge/hold
hfxsd
added
the
do-not-merge/hold
4 participants
What is changed, added or deleted? (Required)
column-privilege-management.md).TOC.mdandprivilege-management.mdto link the new doc.GRANT <privileges>/REVOKE <privileges>docs andmysql-compatibility.mdto reflect column-level privilege support in TiDB v8.5.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
release-8.5-20250606-v8.5.2(column privilege implementation; commits after4f65dffdd6480fc1c36c61fe7cd655f163bc9d41).Do your changes match any of the following descriptions?