Backupandrestore#23286
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
contribution
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TiDB Cloud backup and restore documentation to incorporate the BYOC (Bring Your Own Cloud) plan type, detailing its backup and restore capabilities. The review feedback highlights minor spacing and formatting inconsistencies around template variables like {{{ .premium }}} and {{{ .byoc }}} that should be corrected for consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| - [Automatic backups for {{{ .starter }}} and {{{ .essential }}} instances](/tidb-cloud/backup-and-restore-serverless.md#automatic-backups) | ||
| - [Automatic backups for {{{ .premium }}} instances](/tidb-cloud/premium/backup-and-restore-premium.md#automatic-backups) | ||
| - [Automatic backups for {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc}}} </CustomContent> instances](/tidb-cloud/premium/backup-and-restore-premium.md#automatic-backups) |
There was a problem hiding this comment.
There is an extra space after {{{ .premium }}} and a missing space in {{{ .byoc}}}. Let's adjust the spacing for consistency.
| - [Automatic backups for {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc}}} </CustomContent> instances](/tidb-cloud/premium/backup-and-restore-premium.md#automatic-backups) | |
| - [Automatic backups for {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc }}} </CustomContent> instances](/tidb-cloud/premium/backup-and-restore-premium.md#automatic-backups) |
References
- Correct English grammar, spelling, and punctuation mistakes, if any. Use consistent terminology and formatting. (link)
| Manual backup enables you to back up your data to a known state as needed, and then restore to that state at any time. You can use a manual backup before high-risk operations such as system upgrades, critical data deletion, or irreversible schema changes. | ||
|
|
||
| For more information, see [Perform a manual backup](/tidb-cloud/backup-and-restore.md#perform-a-manual-backup). | ||
| {{{ .premium }}} <CustomContent plan="byoc">, {{{ .byoc}}} </CustomContent> and TiDB Cloud Dedicated support manual backups. A manual backup provides a controlled restore point and is retained until you explicitly delete it. Manual backups do not support PITR or partial backups, and each restore operation creates a new instance. |
There was a problem hiding this comment.
There is a missing space in {{{ .byoc}}} and a double space after the period in manual backups. A manual backup. Let's correct these spacing issues for better consistency and readability.
| {{{ .premium }}} <CustomContent plan="byoc">, {{{ .byoc}}} </CustomContent> and TiDB Cloud Dedicated support manual backups. A manual backup provides a controlled restore point and is retained until you explicitly delete it. Manual backups do not support PITR or partial backups, and each restore operation creates a new instance. | |
| {{{ .premium }}} <CustomContent plan="byoc">, {{{ .byoc }}} </CustomContent> and TiDB Cloud Dedicated support manual backups. A manual backup provides a controlled restore point and is retained until you explicitly delete it. Manual backups do not support PITR or partial backups, and each restore operation creates a new instance. |
References
- Correct English grammar, spelling, and punctuation mistakes, if any. Use consistent terminology and formatting. (link)
|
|
||
| For more information, see the following: | ||
|
|
||
| - [Manual backups for {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc}}} </CustomContent> instances](/tidb-cloud/premium/backup-and-restore-premium.md#manual-backups) |
There was a problem hiding this comment.
There is a missing space in {{{ .byoc}}}. Let's adjust it to {{{ .byoc }}} for consistency.
| - [Manual backups for {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc}}} </CustomContent> instances](/tidb-cloud/premium/backup-and-restore-premium.md#manual-backups) | |
| - [Manual backups for {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc }}} </CustomContent> instances](/tidb-cloud/premium/backup-and-restore-premium.md#manual-backups) |
References
- Correct English grammar, spelling, and punctuation mistakes, if any. Use consistent terminology and formatting. (link)
|
|
||
| TiDB Cloud supports restoring data from backup snapshots or point-in-time recovery to a new cluster or instance. Restore operations help you recover from accidental data loss, data corruption, or application errors. | ||
|
|
||
| For {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc}}} </CustomContent> instances, you can restore data to a new instance. You can restore from automatic backups, manual backups, or supported external cloud storage backups. PITR is supported only for automatic backups and is not supported for manual backups. |
There was a problem hiding this comment.
There is an extra space after {{{ .premium }}} and a missing space in {{{ .byoc}}}. Let's adjust the spacing for consistency.
| For {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc}}} </CustomContent> instances, you can restore data to a new instance. You can restore from automatic backups, manual backups, or supported external cloud storage backups. PITR is supported only for automatic backups and is not supported for manual backups. | |
| For {{{ .premium }}} <CustomContent plan="byoc"> and {{{ .byoc }}} </CustomContent> instances, you can restore data to a new instance. You can restore from automatic backups, manual backups, or supported external cloud storage backups. PITR is supported only for automatic backups and is not supported for manual backups. |
References
- Correct English grammar, spelling, and punctuation mistakes, if any. Use consistent terminology and formatting. (link)
|
@wildpcww: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?