Skip to content

data race in pkg/messaging #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wk989898 opened this issue Apr 14, 2025 · 0 comments · Fixed by #1225
Closed

data race in pkg/messaging #1224

wk989898 opened this issue Apr 14, 2025 · 0 comments · Fixed by #1225
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@wk989898
Copy link
Collaborator

wk989898 commented Apr 14, 2025

What did you do?

Run unit test TestMaintainerSchedulesNodeChanges

What did you expect to see?

No response

What did you see instead?

https://prow.tidb.net/view/gs/prow-tidb-logs/pr-logs/pull/pingcap_ticdc/1103/pull-unit-test/1911741186641498112

==================
WARNING: DATA RACE
Write at 0x00c000998b50 by goroutine 696:
  runtime.racewrite()
      <autogenerated>:1 +0x1e
  golang.org/x/sync/errgroup.(*Group).Wait()
      /home/prow/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:56 +0x37
  github.com/pingcap/ticdc/pkg/messaging.(*remoteMessageTarget).handleIncomingStream()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/remote_target.go:423 +0x5cf
  github.com/pingcap/ticdc/pkg/messaging.(*grpcServer).handleConnect()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/message_center.go:485 +0x1444
  github.com/pingcap/ticdc/pkg/messaging.(*grpcServer).StreamMessages()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/message_center.go:410 +0x3a
  github.com/pingcap/ticdc/pkg/messaging/proto._MessageService_StreamMessages_Handler()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/proto/message_grpc.pb.go:95 +0xe5
  google.golang.org/grpc.(*Server).processStreamingRPC()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1673 +0x1fd9
  google.golang.org/grpc.(*Server).handleStream()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1794 +0x17c4
  google.golang.org/grpc.(*Server).serveStreams.func2.1()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1029 +0x158
Previous read at 0x00c000998b50 by goroutine 695:
  runtime.raceread()
      <autogenerated>:1 +0x1e
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/prow/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:74 +0x7c
  github.com/pingcap/ticdc/pkg/messaging.(*remoteMessageTarget).run()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/remote_target.go:428 +0x146
  github.com/pingcap/ticdc/pkg/messaging.(*remoteMessageTarget).handleIncomingStream()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/remote_target.go:421 +0x5a4
  github.com/pingcap/ticdc/pkg/messaging.(*grpcServer).handleConnect()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/message_center.go:485 +0x1444
  github.com/pingcap/ticdc/pkg/messaging.(*grpcServer).StreamMessages()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/message_center.go:410 +0x3a
  github.com/pingcap/ticdc/pkg/messaging/proto._MessageService_StreamMessages_Handler()
      /home/prow/go/src/github.com/pingcap/ticdc/pkg/messaging/proto/message_grpc.pb.go:95 +0xe5
  google.golang.org/grpc.(*Server).processStreamingRPC()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1673 +0x1fd9
  google.golang.org/grpc.(*Server).handleStream()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1794 +0x17c4
  google.golang.org/grpc.(*Server).serveStreams.func2.1()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1029 +0x158
Goroutine 696 (running) created at:
  google.golang.org/grpc.(*Server).serveStreams.func2()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1040 +0x224
  google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/internal/transport/http2_server.go:630 +0x3941
  google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/internal/transport/http2_server.go:671 +0x406
  google.golang.org/grpc.(*Server).serveStreams()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1023 +0x69b
  google.golang.org/grpc.(*Server).handleRawConn.func1()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:959 +0x86
Goroutine 695 (running) created at:
  google.golang.org/grpc.(*Server).serveStreams.func2()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1040 +0x224
  google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/internal/transport/http2_server.go:630 +0x3941
  google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/internal/transport/http2_server.go:671 +0x406
  google.golang.org/grpc.(*Server).serveStreams()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:1023 +0x69b
  google.golang.org/grpc.(*Server).handleRawConn.func1()
      /home/prow/go/pkg/mod/google.golang.org/[email protected]/server.go:959 +0x86
==================

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant