You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please answer these questions before submitting your issue. Thanks!
What did you do?
Because of refine gc strategy of pump #646
We can see that a formula alertGCTS := gcTS + int64(storage.EncodeTSO(alertGCMS)) adds extra 20h to avoid the scenarios of disk space of the pump is full and much impact on core system formation.
But, the metric and error log aren't accurate and easy understand to user.
ifdrainer.MaxCommitTS<gcTS {
log.Error("drainer's checkpoint is older than pump gc ts, some binlogs are purged",
zap.String("drainer", drainer.NodeID),
zap.Int64("gc ts", gcTS),
zap.Int64("drainer checkpoint", drainer.MaxCommitTS),
)
// will add test when binlog have failpointdetectedDrainerBinlogPurged.WithLabelValues(drainer.NodeID).Inc()
}
}
}
Please provide the relate downstream type and version of drainer.
(run drainer -V in terminal to get drainer's version)
Bug Report
Please answer these questions before submitting your issue. Thanks!
Because of refine gc strategy of pump #646
We can see that a formula
alertGCTS := gcTS + int64(storage.EncodeTSO(alertGCMS))adds extra 20h to avoid the scenarios ofdisk space of the pump is fullandmuch impact on core system formation.But, the metric and error log aren't accurate and easy understand to user.
something likes this one
and gcTs == alertGCTS --> https://github.com/pingcap/tidb-binlog/pull/646/files#diff-d73c6b7c1637ab38367029c88ed0bf596762627453dab635429f991ae9dfc9acR589-R596
(run
drainer -Vin terminal to get drainer's version)