Expose stats ID for use in interceptor factories

Author: mengelbart

interceptor_test.go

@@ -374,7 +374,7 @@ func TestStatsInterceptorIsAddedByDefault(t *testing.T) {
 
 	// Also assert that the getter stored during interceptor Build matches
 	// the one attached to this PeerConnection.
-	getter, ok := lookupStats(pc.statsID)
+	getter, ok := lookupStats(pc.id)
 	assert.True(t, ok, "lookupStats should return a getter for this statsID")
 	assert.NotNil(t, getter)
 	assert.Equal(t,
@@ -392,7 +392,7 @@ func TestStatsGetterCleanup(t *testing.T) {
 
 	assert.NotNil(t, pc.statsGetter, "statsGetter should be non-nil after creation")
 
-	statsID := pc.statsID
+	statsID := pc.id
 	getter, exists := lookupStats(statsID)
 	assert.True(t, exists, "global statsGetter map should contain entry for this PC")
 	assert.NotNil(t, getter, "looked up getter should not be nil")

peerconnection.go

@@ -35,8 +35,8 @@ import (
 // peer-to-peer communications with another PeerConnection instance in a
 // browser, or to another endpoint implementing the required protocols.
 type PeerConnection struct {
-	statsID string
-	mu      sync.RWMutex
+	id string
+	mu sync.RWMutex
 
 	sdpOrigin sdp.Origin
 
@@ -118,7 +118,7 @@ func (api *API) NewPeerConnection(configuration Configuration) (*PeerConnection,
 	// allow better readability to understand what is happening.
 
 	pc := &PeerConnection{
-		statsID: fmt.Sprintf("PeerConnection-%d", time.Now().UnixNano()),
+		id: fmt.Sprintf("PeerConnection-%d", time.Now().UnixNano()),
 		configuration: Configuration{
 			ICEServers:           []ICEServer{},
 			ICETransportPolicy:   ICETransportPolicyAll,
@@ -145,12 +145,12 @@ func (api *API) NewPeerConnection(configuration Configuration) (*PeerConnection,
 	pc.iceConnectionState.Store(ICEConnectionStateNew)
 	pc.connectionState.Store(PeerConnectionStateNew)
 
-	i, err := api.interceptorRegistry.Build(pc.statsID)
+	i, err := api.interceptorRegistry.Build(pc.id)
 	if err != nil {
 		return nil, err
 	}
 
-	if getter, ok := lookupStats(pc.statsID); ok {
+	if getter, ok := lookupStats(pc.id); ok {
 		pc.statsGetter = getter
 	}
 
@@ -597,11 +597,11 @@ func (pc *PeerConnection) GetConfiguration() Configuration {
 	return pc.configuration
 }
 
-func (pc *PeerConnection) getStatsID() string {
+func (pc *PeerConnection) ID() string {
 	pc.mu.RLock()
 	defer pc.mu.RUnlock()
 
-	return pc.statsID
+	return pc.id
 }
 
 // hasLocalDescriptionChanged returns whether local media (rtpTransceivers) has changed
@@ -2482,7 +2482,7 @@ func (pc *PeerConnection) close(shouldGracefullyClose bool) error { //nolint:cyc
 	closeErrs = append(closeErrs, doGracefulCloseOps()...)
 
 	pc.statsGetter = nil
-	cleanupStats(pc.statsID)
+	cleanupStats(pc.id)
 
 	// Interceptor closes at the end to prevent Bind from being called after interceptor is closed
 	closeErrs = append(closeErrs, pc.api.interceptor.Close())
@@ -2623,7 +2623,7 @@ func (pc *PeerConnection) GetStats() StatsReport {
 	stats := PeerConnectionStats{
 		Timestamp:             statsTimestampNow(),
 		Type:                  StatsTypePeerConnection,
-		ID:                    pc.statsID,
+		ID:                    pc.id,
 		DataChannelsAccepted:  dataChannelsAccepted,
 		DataChannelsClosed:    dataChannelsClosed,
 		DataChannelsOpened:    dataChannelsOpened,

stats_go.go

@@ -14,7 +14,7 @@ import (
 
 // GetConnectionStats is a helper method to return the associated stats for a given PeerConnection.
 func (r StatsReport) GetConnectionStats(conn *PeerConnection) (PeerConnectionStats, bool) {
-	statsID := conn.getStatsID()
+	statsID := conn.ID()
 	stats, ok := r[statsID]
 	if !ok {
 		return PeerConnectionStats{}, false

stats_go_test.go

@@ -2037,7 +2037,7 @@ func TestUnmarshalSCTPTransportStats_Error(t *testing.T) {
 
 func TestStatsReport_GetConnectionStats_MissingEntry(t *testing.T) {
 	conn := &PeerConnection{}
-	conn.getStatsID()
+	conn.ID()
 
 	r := StatsReport{}
 	got, ok := r.GetConnectionStats(conn)
@@ -2048,7 +2048,7 @@ func TestStatsReport_GetConnectionStats_MissingEntry(t *testing.T) {
 
 func TestStatsReport_GetConnectionStats_WrongType(t *testing.T) {
 	conn := &PeerConnection{}
-	id := conn.getStatsID()
+	id := conn.ID()
 
 	r := StatsReport{
 		id: DataChannelStats{ID: "not-a-pc-stats"},
@@ -2062,7 +2062,7 @@ func TestStatsReport_GetConnectionStats_WrongType(t *testing.T) {
 
 func TestStatsReport_GetConnectionStats_Success(t *testing.T) {
 	conn := &PeerConnection{}
-	id := conn.getStatsID()
+	id := conn.ID()
 
 	want := PeerConnectionStats{
 		ID:        id,