-
Notifications
You must be signed in to change notification settings - Fork 90
Open
Description
Is your feature request related to a problem? Please describe.
I cannot upgrade to React 17 when using PivotalUI components in my codebase. Our test suite (which uses Enzyme) fails on components using PivotalUI components. e.g. OverlayTrigger
Note: there is a high likelihood that Enzyme just doesn't play well when there are varying React version in-play. But that's for another repo/issue.
Describe the solution you'd like
- Remove
react
from thedependencies
list (it is already listed underpeerDependencies
) - Add
react
to thedevDependencies
list (it is already listed underpeerDependencies
) - Try out React 17 and (assuming it will pass) add
^17
to thereact
semver underpeerDependencies
Describe alternatives you've considered
If it is broken, then that's all right. But I would highly encourage at least cleaning up dependencies
<=> peerDependencies
.
Additional context
Metadata
Metadata
Assignees
Labels
No labels