Skip to content

React 17 #652

@juanca

Description

@juanca

Is your feature request related to a problem? Please describe.

I cannot upgrade to React 17 when using PivotalUI components in my codebase. Our test suite (which uses Enzyme) fails on components using PivotalUI components. e.g. OverlayTrigger

Note: there is a high likelihood that Enzyme just doesn't play well when there are varying React version in-play. But that's for another repo/issue.

Describe the solution you'd like

  1. Remove react from the dependencies list (it is already listed under peerDependencies)
  2. Add react to the devDependencies list (it is already listed under peerDependencies)
  3. Try out React 17 and (assuming it will pass) add ^17 to the react semver under peerDependencies

Describe alternatives you've considered

If it is broken, then that's all right. But I would highly encourage at least cleaning up dependencies <=> peerDependencies.

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions