Enhance calls performance

Author: ismartcoding

app/src/main/java/com/ismartcoding/plain/data/DCall.kt

@@ -1,7 +1,6 @@
 package com.ismartcoding.plain.data
 
-import com.ismartcoding.lib.phonegeo.PhoneNumberLookup
-import com.ismartcoding.lib.phonegeo.algo.LookupAlgorithm
+import com.ismartcoding.plain.features.call.PhoneGeoCache
 import com.ismartcoding.plain.web.models.PhoneGeo
 import kotlin.time.Instant
 
@@ -15,11 +14,5 @@ data class DCall(
     var type: Int,
     val accountId: String,
 ) : IData {
-    fun getGeo(): PhoneGeo? {
-        var geo: PhoneGeo? = null
-        PhoneNumberLookup.instance().with(LookupAlgorithm.IMPL.BINARY_SEARCH).lookup(number)?.let {
-            geo = PhoneGeo(it.geoInfo.province, it.geoInfo.city, it.geoInfo.zipCode, it.geoInfo.areaCode, it.isp.code)
-        }
-        return geo
-    }
+    fun getGeo(): PhoneGeo? = PhoneGeoCache.lookup(number)
 }

app/src/main/java/com/ismartcoding/plain/features/call/PhoneGeoCache.kt

@@ -0,0 +1,39 @@
+package com.ismartcoding.plain.features.call
+
+import androidx.collection.LruCache
+import com.ismartcoding.lib.phonegeo.PhoneNumberLookup
+import com.ismartcoding.lib.phonegeo.algo.LookupAlgorithm
+import com.ismartcoding.plain.web.models.PhoneGeo
+
+/**
+ * LRU cache for phone-number -> PhoneGeo lookups.
+ *
+ * `PhoneNumberLookup` does an in-memory binary search on a 4MB phone.dat
+ * (avg ~19 comparisons, 1-5ms per call). For a 200-row calls page the
+ * same numbers repeat heavily, so caching by raw number string —
+ * including misses for short or unknown numbers — collapses that cost
+ * to one lookup per unique number.
+ *
+ * `LruCache` rejects nullable value types, so a single shared sentinel
+ * stands in for the "not found" case.
+ */
+object PhoneGeoCache {
+    private const val MAX_SIZE = 1024
+    private val MISS: PhoneGeo = PhoneGeo("", "", "", "", 0)
+    private val cache = object : LruCache<String, PhoneGeo>(MAX_SIZE) {
+        override fun sizeOf(key: String, value: PhoneGeo): Int = 1
+    }
+
+    fun lookup(number: String): PhoneGeo? {
+        cache[number]?.let { return it.takeIf { it !== MISS } }
+        val geo = lookupFresh(number)
+        cache.put(number, geo ?: MISS)
+        return geo
+    }
+
+    private fun lookupFresh(number: String): PhoneGeo? =
+        PhoneNumberLookup.instance()
+            .with(LookupAlgorithm.IMPL.BINARY_SEARCH)
+            .lookup(number)
+            ?.let { PhoneGeo(it.geoInfo.province, it.geoInfo.city, it.geoInfo.zipCode, it.geoInfo.areaCode, it.isp.code) }
+}

app/src/main/java/com/ismartcoding/plain/features/media/CallMediaStoreHelper.kt

@@ -6,10 +6,7 @@ import android.net.Uri
 import android.provider.BaseColumns
 import android.provider.CallLog
 import com.ismartcoding.lib.content.ContentWhere
-import com.ismartcoding.lib.data.SortBy
-import com.ismartcoding.lib.data.enums.SortDirection
 import com.ismartcoding.lib.extensions.getIntValue
-import com.ismartcoding.lib.extensions.getPagingCursor
 import com.ismartcoding.lib.extensions.getStringValue
 import com.ismartcoding.lib.extensions.getTimeValue
 import com.ismartcoding.lib.extensions.map
@@ -75,9 +72,17 @@ object CallMediaStoreHelper : BaseContentHelper() {
         limit: Int,
         offset: Int,
     ): List<DCall> {
-        return context.contentResolver.getPagingCursor(
-            uriExternal, getProjection(), buildWhereAsync(query),
-            limit, offset, SortBy(CallLog.Calls._ID, SortDirection.DESC)
+        if (limit <= 0) {
+            return emptyList()
+        }
+
+        val where = buildWhereAsync(query)
+        return context.contentResolver.query(
+            uriExternal.withCallLogPaging(limit, offset),
+            getProjection(),
+            where.toSelection(),
+            where.args.toTypedArray(),
+            "${CallLog.Calls._ID} DESC",
         )?.map { cursor, cache ->
             val id = cursor.getStringValue(CallLog.Calls._ID, cache)
             val number = cursor.getStringValue(CallLog.Calls.NUMBER, cache)
@@ -91,6 +96,20 @@ object CallMediaStoreHelper : BaseContentHelper() {
         } ?: emptyList()
     }
 
+    private fun Uri.withCallLogPaging(
+        limit: Int,
+        offset: Int,
+    ): Uri {
+        return buildUpon()
+            .appendQueryParameter(CallLog.Calls.LIMIT_PARAM_KEY, limit.toString())
+            .apply {
+                if (offset > 0) {
+                    appendQueryParameter(CallLog.Calls.OFFSET_PARAM_KEY, offset.toString())
+                }
+            }
+            .build()
+    }
+
     fun call(
         context: Context,
         number: String,

app/src/main/java/com/ismartcoding/plain/web/schemas/CallGraphQL.kt

@@ -35,7 +35,7 @@ fun SchemaBuilder.addCallSchema() {
     query("callCount") {
         resolver { query: String ->
             val context = MainApp.instance
-            if (Permission.WRITE_CALL_LOG.enabledAndCanAsync(context)) {
+            if (Permission.READ_CALL_LOG.enabledAndCanAsync(context)) {
                 CallMediaStoreHelper.countAsync(context, query)
             } else {
                 0