storage_up doesn't add cluster options?

[StrongFennecs]

Currently mix ecto.create runs -

    statement = "CREATE DATABASE #{@conn.quote_name(database)}"
    ...

If this is running on a cluster, for example configured in ecto_ch options in mixes, does this not also need to be created on the cluster?

[ruslandoga]

👋 @StrongFennecs

does this not also need to be created on the cluster?

Probably, yeah.

If there is a way to check if the SQL needs to contain ON CLUSTER and other modifiers when running storage_up, we should probably add it.

We can start by checking what opts are passed in for different configurations

ecto_ch/lib/ecto/adapters/clickhouse/storage.ex

Lines 8 to 15 in 4121834

	def storage_up(opts) do
	{database, opts} = Keyword.pop!(opts, :database)
	statement = "CREATE DATABASE #{@conn.quote_name(database)}"
	with {:ok, conn} <- Conn.connect(opts),
	{:ok, _result, _conn} <- exec(conn, statement),
	do: :ok
	end

---

But for non-trivial setups -- and I think clustering is one of them -- creating the tables "manually" is safer than using mix ecto.create

[StrongFennecs]

Thanks!

Right, thats probably fine, migrations already have this enabled but thats a bit different. We were bootstrapping out a new replicated test environment and so while ch is a bit new to me - wasn't sure if it was intended to be setup with mix ecto.setup, or if it was a more manual step. Worth making a note in the docs at least? Feel like cluster isn't that uncommon.

Anyway thank you.