Skip to content

Commit e547bbd

Browse files
authored
Refactor Gizmo examples to remove unnecessary 'app' parameter (#7432)
1 parent 19b5a0b commit e547bbd

File tree

5 files changed

+20
-20
lines changed

5 files changed

+20
-20
lines changed

src/extras/gizmo/gizmo.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class Gizmo extends EventHandler {
4444
*
4545
* @event
4646
* @example
47-
* const gizmo = new pc.Gizmo(app, camera, layer);
47+
* const gizmo = new pc.Gizmo(camera, layer);
4848
* gizmo.on('pointer:down', (x, y, meshInstance) => {
4949
* console.log(`Pointer was down on ${meshInstance.node.name} at ${x}, ${y}`);
5050
* });
@@ -56,7 +56,7 @@ class Gizmo extends EventHandler {
5656
*
5757
* @event
5858
* @example
59-
* const gizmo = new pc.Gizmo(app, camera, layer);
59+
* const gizmo = new pc.Gizmo(camera, layer);
6060
* gizmo.on('pointer:move', (x, y, meshInstance) => {
6161
* console.log(`Pointer was moving on ${meshInstance.node.name} at ${x}, ${y}`);
6262
* });
@@ -68,7 +68,7 @@ class Gizmo extends EventHandler {
6868
*
6969
* @event
7070
* @example
71-
* const gizmo = new pc.Gizmo(app, camera, layer);
71+
* const gizmo = new pc.Gizmo(camera, layer);
7272
* gizmo.on('pointer:up', (x, y, meshInstance) => {
7373
* console.log(`Pointer was up on ${meshInstance.node.name} at ${x}, ${y}`);
7474
* })
@@ -80,7 +80,7 @@ class Gizmo extends EventHandler {
8080
*
8181
* @event
8282
* @example
83-
* const gizmo = new pc.Gizmo(app, camera, layer);
83+
* const gizmo = new pc.Gizmo(camera, layer);
8484
* gizmo.on('position:update', (position) => {
8585
* console.log(`The gizmo's position was updated to ${position}`);
8686
* })
@@ -92,7 +92,7 @@ class Gizmo extends EventHandler {
9292
*
9393
* @event
9494
* @example
95-
* const gizmo = new pc.Gizmo(app, camera, layer);
95+
* const gizmo = new pc.Gizmo(camera, layer);
9696
* gizmo.on('rotation:update', (rotation) => {
9797
* console.log(`The gizmo's rotation was updated to ${rotation}`);
9898
* });
@@ -104,7 +104,7 @@ class Gizmo extends EventHandler {
104104
*
105105
* @event
106106
* @example
107-
* const gizmo = new pc.Gizmo(app, camera, layer);
107+
* const gizmo = new pc.Gizmo(camera, layer);
108108
* gizmo.on('scale:update', (scale) => {
109109
* console.log(`The gizmo's scale was updated to ${scale}`);
110110
* });
@@ -116,7 +116,7 @@ class Gizmo extends EventHandler {
116116
*
117117
* @event
118118
* @example
119-
* const gizmo = new pc.Gizmo(app, camera, layer);
119+
* const gizmo = new pc.Gizmo(camera, layer);
120120
* gizmo.on('nodes:attach', () => {
121121
* console.log('Graph nodes attached');
122122
* });
@@ -128,7 +128,7 @@ class Gizmo extends EventHandler {
128128
*
129129
* @event
130130
* @example
131-
* const gizmo = new pc.Gizmo(app, camera, layer);
131+
* const gizmo = new pc.Gizmo(camera, layer);
132132
* gizmo.on('nodes:detach', () => {
133133
* console.log('Graph nodes detached');
134134
* });
@@ -140,7 +140,7 @@ class Gizmo extends EventHandler {
140140
*
141141
* @event
142142
* @example
143-
* const gizmo = new pc.TransformGizmo(app, camera, layer);
143+
* const gizmo = new pc.TransformGizmo(camera, layer);
144144
* gizmo.on('render:update', () => {
145145
* console.log('Gizmo render has been updated');
146146
* });
@@ -250,7 +250,7 @@ class Gizmo extends EventHandler {
250250
* @param {Layer} layer - The render layer. This can be provided by the user or will be created
251251
* and added to the scene and camera if not provided. Successive gizmos will share the same layer
252252
* and will be removed from the camera and scene when the last gizmo is destroyed.
253-
* const gizmo = new pc.Gizmo(app, camera, layer);
253+
* const gizmo = new pc.Gizmo(camera, layer);
254254
*/
255255
constructor(camera, layer) {
256256
Debug.assert(camera instanceof CameraComponent, 'Incorrect parameters for Gizmos\'s constructor. Use new Gizmo(camera, layer)');
@@ -527,7 +527,7 @@ class Gizmo extends EventHandler {
527527
*
528528
* @param {GraphNode[] | GraphNode} [nodes] - The graph nodes. Defaults to [].
529529
* @example
530-
* const gizmo = new pc.Gizmo(app, camera, layer);
530+
* const gizmo = new pc.Gizmo(camera, layer);
531531
* gizmo.attach([boxA, boxB]);
532532
*/
533533
attach(nodes = []) {
@@ -554,7 +554,7 @@ class Gizmo extends EventHandler {
554554
* Detaches all graph nodes from the gizmo.
555555
*
556556
* @example
557-
* const gizmo = new pc.Gizmo(app, camera, layer);
557+
* const gizmo = new pc.Gizmo(camera, layer);
558558
* gizmo.attach([boxA, boxB]);
559559
* gizmo.detach();
560560
*/
@@ -571,7 +571,7 @@ class Gizmo extends EventHandler {
571571
* Detaches all graph nodes and destroys the gizmo instance.
572572
*
573573
* @example
574-
* const gizmo = new pc.Gizmo(app, camera, layer);
574+
* const gizmo = new pc.Gizmo(camera, layer);
575575
* gizmo.attach([boxA, boxB]);
576576
* gizmo.destroy();
577577
*/

src/extras/gizmo/rotate-gizmo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ class RotateGizmo extends TransformGizmo {
147147
* @param {CameraComponent} camera - The camera component.
148148
* @param {Layer} layer - The render layer.
149149
* @example
150-
* const gizmo = new pc.RotateGizmo(app, camera, layer);
150+
* const gizmo = new pc.RotateGizmo(camera, layer);
151151
*/
152152
constructor(camera, layer) {
153153
super(camera, layer);

src/extras/gizmo/scale-gizmo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class ScaleGizmo extends TransformGizmo {
129129
* @param {CameraComponent} camera - The camera component.
130130
* @param {Layer} layer - The render layer.
131131
* @example
132-
* const gizmo = new pc.ScaleGizmo(app, camera, layer);
132+
* const gizmo = new pc.ScaleGizmo(camera, layer);
133133
*/
134134
constructor(camera, layer) {
135135
super(camera, layer);

src/extras/gizmo/transform-gizmo.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class TransformGizmo extends Gizmo {
4646
*
4747
* @event
4848
* @example
49-
* const gizmo = new pc.TransformGizmo(app, camera, layer);
49+
* const gizmo = new pc.TransformGizmo(camera, layer);
5050
* gizmo.on('transform:start', () => {
5151
* console.log('Transformation started');
5252
* });
@@ -58,7 +58,7 @@ class TransformGizmo extends Gizmo {
5858
*
5959
* @event
6060
* @example
61-
* const gizmo = new pc.TransformGizmo(app, camera, layer);
61+
* const gizmo = new pc.TransformGizmo(camera, layer);
6262
* gizmo.on('transform:move', (pointDelta, angleDelta) => {
6363
* console.log('Transformation moved by ${pointDelta} (angle: ${angleDelta})');
6464
* });
@@ -70,7 +70,7 @@ class TransformGizmo extends Gizmo {
7070
*
7171
* @event
7272
* @example
73-
* const gizmo = new pc.TransformGizmo(app, camera, layer);
73+
* const gizmo = new pc.TransformGizmo(camera, layer);
7474
* gizmo.on('transform:end', () => {
7575
* console.log('Transformation ended');
7676
* });
@@ -247,7 +247,7 @@ class TransformGizmo extends Gizmo {
247247
* @param {CameraComponent} camera - The camera component.
248248
* @param {Layer} layer - The render layer.
249249
* @example
250-
* const gizmo = new pc.TransformGizmo(app, camera, layer);
250+
* const gizmo = new pc.TransformGizmo(camera, layer);
251251
*/
252252
constructor(camera, layer) {
253253
super(camera, layer);

src/extras/gizmo/translate-gizmo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class TranslateGizmo extends TransformGizmo {
126126
* @param {CameraComponent} camera - The camera component.
127127
* @param {Layer} layer - The render layer.
128128
* @example
129-
* const gizmo = new pc.TranslateGizmo(app, camera, layer);
129+
* const gizmo = new pc.TranslateGizmo(camera, layer);
130130
*/
131131
constructor(camera, layer) {
132132
super(camera, layer);

0 commit comments

Comments
 (0)