Merge pull request #7 from playcanvas/exit-code

return 1 always as a failure code

Author: isumygin-sc

convert.py

@@ -36,6 +36,8 @@
 magick_command = '"{}"'.format(args.magick_executable) if len(args.magick_executable) > 0 else "magick"
 use_gpu = 1 if not args.no_gpu else 0
 
+EXIT_FAIL = 1
+
 if not args.skip_matching:
     os.makedirs(args.source_path + "/distorted/sparse", exist_ok=True)
 
@@ -49,7 +51,7 @@
     exit_code = os.system(feat_extracton_cmd)
     if exit_code != 0:
         logging.error(f"Feature extraction failed with code {exit_code}. Exiting.")
-        exit(exit_code)
+        exit(EXIT_FAIL)
 
     ## Feature matching
     feat_matching_cmd = colmap_command + " exhaustive_matcher \
@@ -58,7 +60,7 @@
     exit_code = os.system(feat_matching_cmd)
     if exit_code != 0:
         logging.error(f"Feature matching failed with code {exit_code}. Exiting.")
-        exit(exit_code)
+        exit(EXIT_FAIL)
 
     ### Bundle adjustment
     # The default Mapper tolerance is unnecessarily large,
@@ -71,7 +73,7 @@
     exit_code = os.system(mapper_cmd)
     if exit_code != 0:
         logging.error(f"Mapper failed with code {exit_code}. Exiting.")
-        exit(exit_code)
+        exit(EXIT_FAIL)
 
     ### Convert model to text format so we can read cameras
     convert_cmd = (colmap_command + " model_converter \
@@ -81,7 +83,7 @@
     exit_code = os.system(convert_cmd)
     if exit_code != 0:
         logging.error(f"Convert failed with code {exit_code}. Exiting.")
-        exit(exit_code)
+        exit(EXIT_FAIL)
 
 ### Image undistortion
 ## We need to undistort our images into ideal pinhole intrinsics.
@@ -94,7 +96,7 @@
 exit_code = os.system(img_undist_cmd)
 if exit_code != 0:
     logging.error(f"image_undistorter failed with code {exit_code}. Exiting.")
-    exit(exit_code)
+    exit(EXIT_FAIL)
 
 
 def remove_dir_if_exist(path):
@@ -114,7 +116,7 @@ def remove_dir_if_exist(path):
     exit_code = os.system(model_converter_cmd)
     if exit_code != 0:
         logging.error(f"model_converter failed with code {exit_code}. Exiting.")
-        exit(exit_code)
+        exit(EXIT_FAIL)
 
     # replace '.jpg' to '.png'
     with open(args.source_path + "/alpha_distorted_sparse_txt/images.txt", "r+") as f:
@@ -133,7 +135,7 @@ def remove_dir_if_exist(path):
     exit_code = os.system(seg_undist_cmd)
     if exit_code != 0:
         logging.error(f"image_undistorter for segs failed with code {exit_code}. Exiting.")
-        exit(exit_code)
+        exit(EXIT_FAIL)
 
     # switch images
     remove_dir_if_exist(f'{args.source_path}/alpha_undistorted_sparse/alphas')
@@ -188,20 +190,20 @@ def concat_alpha(seg_path):
         exit_code = os.system("mogrify -resize 50% " + destination_file)
         if exit_code != 0:
             logging.error(f"50% resize failed with code {exit_code}. Exiting.")
-            exit(exit_code)
+            exit(EXIT_FAIL)
 
         destination_file = os.path.join(args.source_path, "images_4", file)
         shutil.copy2(source_file, destination_file)
         exit_code = os.system("mogrify -resize 25% " + destination_file)
         if exit_code != 0:
             logging.error(f"25% resize failed with code {exit_code}. Exiting.")
-            exit(exit_code)
+            exit(EXIT_FAIL)
 
         destination_file = os.path.join(args.source_path, "images_8", file)
         shutil.copy2(source_file, destination_file)
         exit_code = os.system("mogrify -resize 12.5% " + destination_file)
         if exit_code != 0:
             logging.error(f"12.5% resize failed with code {exit_code}. Exiting.")
-            exit(exit_code)
+            exit(EXIT_FAIL)
 
 print("Done.")