Set action *and* pageAction on Firefox.

Fixes #67

Author: pmarks-net

src/background.js

@@ -143,6 +143,24 @@ function reformatForNAT64(addr, doLookup=true) {
   return formatIPv6(packed128, /*with_dots=*/isNAT64);
 }
 
+// Magic object that calls action and/or pageAction. We want an icon in the
+// address bar when possible (e.g. desktop Firefox) but have a fallback option
+// when browsers forget to implement pageAction (e.g. Firefox 142 for Android).
+const actions = new Proxy({}, {
+  get(target, prop) {
+    const apis = [chrome.action, chrome.pageAction].filter(Boolean);
+    return (...args) => {
+      for (const api of apis) {
+        if (typeof api[prop] === 'function') {
+          api[prop](...args);
+        } else if (prop != 'show') {  // action.show() shouldn't exist.
+          throw new Error(`actions.${prop} is not a function`);
+        }
+      }
+    };
+  }
+});
+
 class SaveableEntry {
   #prefix;
   #id;
@@ -420,13 +438,9 @@ class TabInfo extends SaveableEntry {
     if (has4) pattern += "4";
     if (has6) pattern += "6";
 
-    // Firefox might drop support for pageAction someday, but until then
-    // let's keep the icon in the address bar.
-    const action = chrome.pageAction || chrome.action;
-
     // Don't waste time rewriting the same tooltip.
     if (this.lastTooltip != tooltip) {
-      action.setTitle({
+      actions.setTitle({
         "tabId": this.id(),
         "title": tooltip,
       });
@@ -440,7 +454,7 @@ class TabInfo extends SaveableEntry {
       if (color == "auto") {
         color = darkMode.value ? "lightfg" : "darkfg";
       }
-      action.setIcon({
+      actions.setIcon({
         "tabId": this.id(),
         "imageData": {
           "16": buildIcon(pattern, 16, color),
@@ -449,13 +463,11 @@ class TabInfo extends SaveableEntry {
       });
       // Send icon to the popup window (mobile only)
       popups.pushPattern(this.id(), pattern);
-      action.setPopup({
+      actions.setPopup({
         "tabId": this.id(),
         "popup": `popup.html#${this.id()}`,
       });
-      if (action.show) {
-        action.show(this.id());  // Firefox only
-      }
+      actions.show(this.id());
       this.lastPattern = pattern;
       this.save();
     }

src/manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "IPvFoo",
   "manifest_version": 3,
-  "version": "2.24",
+  "version": "2.25",
   "description": "Display the server IP address, with a realtime summary of IPv4, IPv6, and HTTPS information across all page elements.",
   "homepage_url": "https://github.com/pmarks-net/ipvfoo",
   "icons": {

src/manifest/chrome-manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "IPvFoo",
   "manifest_version": 3,
-  "version": "2.24",
+  "version": "2.25",
   "description": "Display the server IP address, with a realtime summary of IPv4, IPv6, and HTTPS information across all page elements.",
   "homepage_url": "https://github.com/pmarks-net/ipvfoo",
   "icons": {

src/manifest/firefox-manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "IPvFoo",
   "manifest_version": 3,
-  "version": "2.24",
+  "version": "2.25",
   "description": "Display the server IP address, with a realtime summary of IPv4, IPv6, and HTTPS information across all page elements.",
   "homepage_url": "https://github.com/pmarks-net/ipvfoo",
   "icons": {
@@ -20,6 +20,11 @@
       "strict_min_version": "120.0"
     }
   },
+  "action": {
+    "default_icon": {
+      "16": "icon16_transparent.png"
+    }
+  },
   "page_action": {
     "default_icon": {
       "16": "icon16_transparent.png"