Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket::select() should not be deprecated #4885

Open
obiltschnig opened this issue Feb 27, 2025 · 4 comments
Open

Socket::select() should not be deprecated #4885

obiltschnig opened this issue Feb 27, 2025 · 4 comments
Assignees
Labels

Comments

@obiltschnig
Copy link
Member

I don't think Socket::select() should be deprecated. It's still useful for some use cases where one just needs to check a few sockets.

@obiltschnig obiltschnig self-assigned this Feb 27, 2025
@obiltschnig obiltschnig added this to the Release 1.14.2 milestone Feb 27, 2025
@SinghRajenM
Copy link
Contributor

SinghRajenM commented Mar 3, 2025

Even we are using it and this change forces us to do a lot more code changes. Though, we can compile POCO using POCO_SILENCE_DEPRECATED to suppress this warning. But this will be our last resort as this not only suppresses for Socket::select, but for others APIs too.

FYI - currently, we are using older version e.g. 1.11.x and migrating to 1.14.x.

@aleks-f aleks-f added this to 1.14 Mar 3, 2025
@matejk
Copy link
Contributor

matejk commented Mar 19, 2025

select() was marked as deprecated in #1459.

It seems like a good idea to deprecate select().

@aleks-f
Copy link
Member

aleks-f commented Mar 19, 2025

it would make sense to keep it if we make it just a simple wrapper for the platform select(). Whoever needs poll, should use Socket::poll().

@obiltschnig
Copy link
Member Author

That would make sense. What I'd like to avoid is forcing people (including myself) to rewrite their code to use PollSet instead of select() for use cases where select() is just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants