-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for WSL desktop integration #53
Comments
@wychwitch Please give |
@wychwitch One last try... I think I know what is going on. Perhaps you are running that command from bash. Bash does not substitute
|
@wychwitch Awesome! Will figure the zsh mystery... Like why it works for some commands and not for others. For instance echo on zsh will translate
|
@poetaman YEP \r works the same!! That's fantastic, it'll make adapting the script easier :) As for the ZSH thing, it could be my zshrc maybe? |
Most likely it is just a few special print builtins like |
Hey - I see that you are using My motivation when creating it was to create something that can be aliased to If you're not so concerned about the argument compatibility with |
@wychwitch Please do git pull, install and run arttime again. You can even run arttime without installing, just cd to the top of its clone and run @stuartleeks Yes, I don't have a machine that can run WSL or this feature would have been tested in past... It would be great if you could also give it a try. Also, do options like |
@poetaman oh im so sorry ive been swamped with the end of school Ill totally do this tomorrow!! I cant wait to try it out ^^ |
YESS it works!! I tried this by doing cloning a new repo and running it with ./bin/arttime like you suggested! It's the normal windows notification sound in case you tried to customize it, but it works great! Thank you so much! Let me know if there's anything else you'd like for me to test ^^ |
@wychwitch: Awesome! A couple of questions:
More testing is always welcome. If you feel like, please play with arttime's features and post your testing experience on https://github.com/poetaman/arttime/discussions. The screencast below shows how notifications show up on macOS. On Linux, the way multiple notifications are handled depends on DE (Desktop Environment). Some Linux DEs show only 1 notification at a time on the screen, and the next is shown in the same place once you click on the currently show notification (oldest unclicked). On other DEs, each new notification is shown on an empty space on screen. That happens till all space is filled with notifications, and notifications start stacking. Just curious what happened to the other 3 notifications for this test you ran? 5ssprint4.mp4 |
OH I know what happened with the 3/4 and the 4/4 goals difference. This actually has to do with your question about notification behavior! On windows, a notification is shown onscreen for a few seconds before automatically timing out and disappearing (only like, 5 seconds or so). If multiple notifications show up back to back, rather than OSX the notifications wont "stack", instead it will take its time to cycle through them one by one. I'm not sure if this behavior can be overwritten? But yes, in that screenshot I'm pretty sure the difference happened because the 3/4 notification hadn't gone away when I took the screenshot, which meant the 4/4 one was queued up behind it! I didn't even notice hahahw As for installing wsl-notify, it was pretty easy! I wasn't able to figure out how to properly get it working as a function in nushell (my shell of choice) but considering how different nushell's scripting is it's not surprising lmao I hope that clears things up!! I'll do more testing when I get to the computer |
@wychwitch Yes yes! That does clear things a lot. When you get to your computer, please try
|
@poetaman Oh I just got to the computer, and I realized after checking help that the urgency flag is completely ignored in wsl-notify!
Sure enough, they don't stay onscreen! Here's the video recorded: EDIT: Well that didn't embed lmao, hold on here's a gif version |
@stuartleeks Is it possible to get the effect of @wychwitch Thanks! At least they are ordered, which is good enough for now. Did you hear the sound accompanying notification 5 times (synchronized with it)? That would be my guess... |
@poetaman yep! The sound happens for each time the notification pops up! and no problem, I'm happy to help! |
This can be closed as desktop notifications work on Windows under WSL since release 2.1.0. For persistence/timeout of notifications, I have filed a feature request on wsl-notify-send here: stuartleeks/wsl-notify-send#8. |
As visible from @wychwitch's testing in arttime discussions, it is possible to add desktop integration for arttime running in WSL.
The text was updated successfully, but these errors were encountered: