Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore links per-crate? #40

Open
jyn514 opened this issue Dec 1, 2020 · 3 comments
Open

Ignore links per-crate? #40

jyn514 opened this issue Dec 1, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jyn514
Copy link
Contributor

jyn514 commented Dec 1, 2020

Right now you can ignore links globally:

[ignore]
"name" = [ "link 1" ]

and per-file:

["tracing-core/src/lib.rs"]
"`downcast_ref`" = [ "#method.downcast_ref" ]

but not per crate. It would be nice to be able to say "ignore links to String, but only in the core crate".

I'm not sure how to fit that in to the existing syntax - I think we might have hemmed ourselves in by getting too clever with the keys. Maybe something like this?

[[crate]]
name = "core"
"String" = "../../std/str/struct.String.html"

That means you can't ignore a name link I think, but I'm not sure what other syntax intra-conv could use.

@poliorcetics poliorcetics added the enhancement New feature or request label Dec 1, 2020
@poliorcetics
Copy link
Owner

I never understood toml tables.

I agree this would be nice to have but I'm not sure how to fix it. Your proposed syntax is nice but I don't want to lock people out of using name or any other identifier within a crate-wide ignore.

The current solution is to have an ignore file per-crate but this obviously does not scale well.

I'll think about it some more before making a choice.

@jyn514
Copy link
Contributor Author

jyn514 commented Dec 2, 2020

The current solution is to have an ignore file per-crate but this obviously does not scale well.

Oh I didn't think of that - that would probably work for me. I'm not sure how intraconv detects crates though, I think if I run it in the root of a workspace it will use the same ignore file for each?

@poliorcetics
Copy link
Owner

Yes, you would have to run it for each crate separately and either give it a specific ignore file or put one in each crate directory and run intraconv from this directory. Not very agreeable to use but it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants