Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not force reboot after changes #3

Open
2 tasks done
brajjan opened this issue Oct 21, 2022 · 0 comments
Open
2 tasks done

Do not force reboot after changes #3

brajjan opened this issue Oct 21, 2022 · 0 comments

Comments

@brajjan
Copy link

brajjan commented Oct 21, 2022

Prerequisites

Put an X between the brackets on each line to confirm you have completed them:

  • The issue is still present in the latest version of the module.
  • The issue has not been previously reported.

Description

The Set-TargetResource includes $global:DSCMachineStatus = 1 and forces a reboot of the node if LCM is configured with RebootNodeIfNeeded = $true

This should not be set in the resource but instead let users decide if you want to restart the node and call a separate reboot resoruce

Suggestion: Remove $global:DSCMachineStatus = 1 from Set-TargetResource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brajjan