Add string node type. Fixes #25.

Author: ben-eb

API.md

@@ -132,6 +132,19 @@ Arguments:
 
 * `props (object)`: The new node's properties.
 
+### `parser.string([props])`
+
+Creates a new string node.
+
+```js
+parser.string();
+// => (empty)
+```
+
+Arguments:
+
+* `props (object)`: The new node's properties.
+
 ### `parser.tag([props])`
 
 Creates a new tag selector.
@@ -164,7 +177,7 @@ Arguments:
 
 A string representation of the selector type. It can be one of the following;
 `attribute`, `class`, `combinator`, `comment`, `id`, `pseudo`, `root`,
-`selector`, `tag`, or `universal`.
+`selector`, `string`, `tag`, or `universal`.
 
 ```js
 parser.attribute({attribute: 'href'}).type;

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.3.0
+
+* Adds a new node type, `String`, to fix a crash on selectors such as
+  `foo:bar("test")`.
+
 # 1.2.1
 
 * Fixes a crash when the parser encountered a trailing combinator.

src/__tests__/parser.js

@@ -1,3 +1,5 @@
+'use strict';
+
 import test from 'tape';
 import parser from '../index';
 
@@ -37,13 +39,19 @@ test('parser#pseudo', (t) => {
     t.equal(String(node), '::before');
 });
 
+test('parser#string', (t) => {
+    let node = parser.string({value: '"wow"'});
+    t.plan(1);
+    t.equal(String(node), '"wow"');
+});
+
 test('parser#tag', (t) => {
     let node = parser.tag({value: 'button'});
     t.plan(1);
     t.equal(String(node), 'button');
 });
 
-test('parser#tag', (t) => {
+test('parser#universal', (t) => {
     let node = parser.universal();
     t.plan(1);
     t.equal(String(node), '*');

src/__tests__/pseudos.js

@@ -90,3 +90,9 @@ test('extraneous non-combinating whitespace', '  h1:after   ,  h2:after   ', (t,
     t.equal(tree.nodes[1].nodes[1].value, ':after');
     t.equal(tree.nodes[1].nodes[1].spaces.after, '   ');
 });
+
+test('negation pseudo element with quotes', 'h1:not(".heading")', (t, tree) => {
+    t.plan(2);
+    t.equal(tree.nodes[0].nodes[1].value, ':not');
+    t.equal(tree.nodes[0].nodes[1].nodes[0].nodes[0].value, '".heading"');
+});

src/index.js

@@ -9,12 +9,13 @@ import Id         from './selectors/id';
 import Pseudo     from './selectors/pseudo';
 import Root       from './selectors/root';
 import Selector   from './selectors/selector';
+import Str        from './selectors/string';
 import Tag        from './selectors/tag';
 import Universal  from './selectors/universal';
 
 let parser = function (processor) {
     return new Processor(processor);
-}
+};
 
 parser.attribute = function (opts) {
     return new Attribute(opts);
@@ -30,7 +31,7 @@ parser.combinator = function (opts) {
 
 parser.comment = function (opts) {
     return new Comment(opts);
-}
+};
 
 parser.id = function (opts) {
     return new Id(opts);
@@ -48,6 +49,10 @@ parser.selector = function (opts) {
     return new Selector(opts);
 };
 
+parser.string = function (opts) {
+    return new Str(opts);
+};
+
 parser.tag = function (opts) {
     return new Tag(opts);
 };

src/parser.js

@@ -6,6 +6,7 @@ import ClassName from './selectors/className';
 import Comment from './selectors/comment';
 import ID from './selectors/id';
 import Tag from './selectors/tag';
+import Str from './selectors/string';
 import Pseudo from './selectors/pseudo';
 import Attribute from './selectors/attribute';
 import Universal from './selectors/universal';
@@ -69,7 +70,7 @@ export default class Parser {
         } else {
             attributeProps.attribute = parts[0];
         }
-        attr = new Attribute(attributeProps)
+        attr = new Attribute(attributeProps);
 
         if (parts[2]) {
             let insensitive = parts[2].split(/(\s+i\s*?)$/);
@@ -259,6 +260,25 @@ export default class Parser {
         }
     }
 
+    string () {
+        let token = this.currToken;
+        this.newNode(new Str({
+            value: this.currToken[1],
+            source: {
+                start: {
+                    line: token[2],
+                    column: token[3]
+                },
+                end: {
+                    line: token[4],
+                    column: token[5]
+                }
+            },
+            sourceIndex: token[6]
+        }));
+        this.position++;
+    }
+
     universal (namespace) {
         let nextToken = this.nextToken;
         if (nextToken && nextToken[1] === '|') {
@@ -405,6 +425,9 @@ export default class Parser {
             case 'combinator':
                 this.combinator();
                 break;
+            case 'string':
+                this.string();
+                break;
         }
     }
 

src/selectors/string.js

@@ -0,0 +1,10 @@
+'use strict';
+
+import Node from './node';
+
+export default class String extends Node {
+    constructor (opts) {
+        super(opts);
+        this.type = 'string';
+    }
+}