Skip to content

restore and pg_control #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gsmolk opened this issue Feb 2, 2021 · 1 comment · May be fixed by #399
Open

restore and pg_control #313

gsmolk opened this issue Feb 2, 2021 · 1 comment · May be fixed by #399
Labels
enhancement

Comments

@gsmolk
Copy link
Contributor

gsmolk commented Feb 2, 2021

To prevent instance from starting in the middle of restore:

  1. When running regular restore, we must copy pg_control at the very end.
  2. When running incremental restore, we must drop pg_control first.
@gsmolk gsmolk added this to the 2.5.0 milestone Feb 2, 2021
@gsmolk
Copy link
Contributor Author

gsmolk commented May 17, 2021 

INFO: Running incremental restore into nonempty directory: "/data/postgresql"
INFO: Trying to read pg_control file in destination direstory
ERROR: Could not open file "/data/postgresql/global/pg_control" for reading: No such file or directory

kulaginm added a commit that referenced this issue Jun 16, 2021
@kulaginm
[Issue #313] restore pg_control last
a6f3b12
@kulaginm kulaginm linked a pull request Jun 16, 2021 that will close this issue
[Issue #313] restore pg_control last #399
Open
gsmolk added a commit that referenced this issue Jun 16, 2021
@gsmolk
[Issue #313] review feedback
0ef2339
gsmolk added a commit that referenced this issue Jun 16, 2021
@gsmolk
[Issue #313] added test coverage
6e8e948
gsmolk added a commit that referenced this issue Jun 16, 2021
@gsmolk
[Issue #313] improve test coverage
447f0a6
kulaginm added a commit that referenced this issue Jun 18, 2021
@kulaginm
[Issue #313] add test incr_restore.IncrRestoreTest.test_incr_restore_…
11ef028 
…issue_313
@kulaginm kulaginm modified the milestones: 2.5.2, 2.5.3 Oct 15, 2021
@kulaginm kulaginm modified the milestones: 2.5.4, 2.5.5 Dec 22, 2021
@kulaginm kulaginm modified the milestones: 2.5.5, 2.5.6 Feb 16, 2022
@kulaginm kulaginm modified the milestones: 2.5.6, 2.5.7 May 26, 2022
@Burus Burus removed this from the 2.5.7 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #313] restore pg_control last postgrespro/pg_probackup
3 participants
@Burus @gsmolk @kulaginm