Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACVP: Consider adding preHash/external-mu test cases #39

Open
mkannwischer opened this issue Feb 22, 2025 · 1 comment
Open

ACVP: Consider adding preHash/external-mu test cases #39

mkannwischer opened this issue Feb 22, 2025 · 1 comment

Comments

@mkannwischer
Copy link
Contributor

mkannwischer commented Feb 22, 2025

FIPS-204 has a preHashing mode that passes a hash of the message instead of the full message.

ACVP has test cases for the preHash mode with the external hash being one of
"SHA2-224", "SHA2-256", "SHA2-384", "SHA2-512", "SHA2-512/224", "SHA2-512/256", "SHA3-224", "SHA3-256", "SHA3-384", "SHA3-512", "SHAKE-128", "SHAKE-256".

Currently these test cases are being skipped as the current code does not support pre-hashing.
Do we want to support pre-hashing?

It is also allowed to compute the entirety of mu <- H(BytesToBits(𝑡𝑟)||𝑀′, 64) externally.

@mkannwischer mkannwischer changed the title ACVP: Consider adding preHash test cases ACVP: Consider adding preHash/external-mu test cases Feb 22, 2025
@jakemas
Copy link
Contributor

jakemas commented Mar 4, 2025

Yes! I think we should add pre-hash modes. I plan to implement external mu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants