Skip to content

Commit 6b804fe

Browse files
authored
Merge pull request #61 from circAssimilate/fix/60/unified_expand_without_line_numbers
fix(601): Fix unified view without line numbers expand cell bug
2 parents fa46e6d + 62b7bb1 commit 6b804fe

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

src/index.tsx

+18-5
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ class DiffViewer extends React.Component<ReactDiffViewerProps, ReactDiffViewerSt
415415
leftBlockLineNumber: number,
416416
rightBlockLineNumber: number,
417417
): JSX.Element => {
418-
const { splitView } = this.props;
418+
const { hideLineNumbers, splitView } = this.props;
419419
const message = this.props.codeFoldMessageRenderer
420420
? this.props
421421
.codeFoldMessageRenderer(num, leftBlockLineNumber, rightBlockLineNumber)
@@ -427,14 +427,27 @@ class DiffViewer extends React.Component<ReactDiffViewerProps, ReactDiffViewerSt
427427
</a>
428428
</td>
429429
);
430+
const isUnifiedViewWithoutLineNumbers = !splitView && !hideLineNumbers;
430431
return (
431432
<tr key={`${leftBlockLineNumber}-${rightBlockLineNumber}`} className={this.styles.codeFold}>
432-
{!this.props.hideLineNumbers && (
433+
{!hideLineNumbers && (
433434
<td className={this.styles.codeFoldGutter} />
434435
)}
435-
<td className={cn({ [this.styles.codeFoldGutter]: !splitView })} />
436-
{splitView ? content : <td />}
437-
{!splitView ? content : <td />}
436+
<td className={cn({ [this.styles.codeFoldGutter]: isUnifiedViewWithoutLineNumbers })} />
437+
438+
{/* Swap columns only for unified view without line numbers */}
439+
{isUnifiedViewWithoutLineNumbers ? (
440+
<React.Fragment>
441+
<td />
442+
{content}
443+
</React.Fragment>
444+
) : (
445+
<React.Fragment>
446+
{content}
447+
<td />
448+
</React.Fragment>
449+
)}
450+
438451
<td />
439452
<td />
440453
</tr>

0 commit comments

Comments
 (0)