Skip to content

Commit 9959e0c

Browse files
committed
Address review comments
1 parent 68a3b76 commit 9959e0c

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

presto-docs/src/main/sphinx/connector/iceberg.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1236,12 +1236,12 @@ Examples:
12361236
Rewrite Data Files
12371237
^^^^^^^^^^^^^^^^^^
12381238

1239-
Iceberg tracks all data files under different partition specs in a table. More data files requires
1240-
more metadata to be stored in manifest files, and small data files can cause unnecessary amount metadata and
1241-
less efficient queries from file open costs. Also, data files under different partition specs can
1239+
Iceberg tracks all data files under different partition specs in a table. More data files require
1240+
more metadata to be stored in manifest files, and small data files can cause an unnecessary amount of metadata and
1241+
less efficient queries due to file open costs. Also, data files under different partition specs can
12421242
prevent metadata level deletion or thorough predicate push down for Presto.
12431243

1244-
Use `rewrite_data_files` to rewrite the data files of a specified table so that they are
1244+
Use ``rewrite_data_files`` to rewrite the data files of a specified table so that they are
12451245
merged into fewer but larger files under the newest partition spec. If the table is partitioned, the data
12461246
files compaction can act separately on the selected partitions to improve read performance by reducing
12471247
metadata overhead and runtime file open cost.

presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,6 +1097,7 @@ public void finishCallDistributedProcedure(ConnectorSession session, ConnectorDi
10971097
((DistributedProcedure) procedure).finish(procedureContext.get(), procedureHandle, fragments);
10981098
transaction.commitTransaction();
10991099
procedureContext.get().destroy();
1100+
procedureContext = Optional.empty();
11001101
}
11011102

11021103
@Override

presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergProcedureContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,6 @@ public void destroy()
9090
this.scannedDataFiles.clear();
9191
this.fullyAppliedDeleteFiles.clear();
9292
this.connectorSplitSource.ifPresent(ConnectorSplitSource::close);
93-
this.connectorSplitSource = null;
93+
this.connectorSplitSource = Optional.empty();
9494
}
9595
}

0 commit comments

Comments
 (0)