-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method ordering #88
Comments
Generally -1 to this, I like the idea but it's too prescriptive |
@acbramley mainly I think private/public/static are the most disruptive, the other rules are essentially what we are disciplined enough to follow anyway. I've modified IS with an alternate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SlevomatCodingStandard.Classes.ClassStructure
has been enhanced. We can now add more detailed method ordering rules now that some issues/PR solved:Proposal 1
Summary of proposed rules:
invoke method
Proposal 2 / Alternate
As visible in a demo PR (not linked), theres quite a large LOC change for proposal 1.
Taking from proposal, but changing some things:
Defer or reconsider static/protected/private ordering.
And
actions()
/save()
.Most others would keep their position simply due to discipline.
The text was updated successfully, but these errors were encountered: