We used to handle 501 before we moved to java-http because we had to parse the http verb into a servlet enum.

We can now handle any value w/out explosion, but we still only map out standard methods in the DefaultActionConfigurationBuilder.

So this is just to fix the error to be more accurate, which is what we used to do.

Author: robotdan

build.savant

@@ -29,7 +29,7 @@ logbackVersion = "1.5.13"
 slf4jVersion = "2.0.13"
 testngVersion = "7.8.0"
 
-project(group: "org.primeframework", name: "prime-mvc", version: "5.2.0", licenses: ["ApacheV2_0"]) {
+project(group: "org.primeframework", name: "prime-mvc", version: "5.3.0", licenses: ["ApacheV2_0"]) {
   workflow {
     fetch {
       // Dependency resolution order:

pom.xml

@@ -5,7 +5,7 @@
 
   <groupId>org.primeframework</groupId>
   <artifactId>prime-mvc</artifactId>
-  <version>5.1.1</version>
+  <version>5.3.0</version>
   <packaging>jar</packaging>
 
   <name>FusionAuth App</name>

src/main/java/org/primeframework/mvc/action/DefaultActionMappingWorkflow.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2001-2024, Inversoft Inc., All Rights Reserved
+ * Copyright (c) 2001-2025, Inversoft Inc., All Rights Reserved
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@
 import io.fusionauth.http.server.HTTPRequest;
 import io.fusionauth.http.server.HTTPResponse;
 import org.primeframework.mvc.NotAllowedException;
+import org.primeframework.mvc.NotImplementedException;
 import org.primeframework.mvc.http.HTTPTools;
 import org.primeframework.mvc.http.Status;
 import org.primeframework.mvc.parameter.fileupload.annotation.FileUpload;
@@ -93,7 +94,15 @@ public void perform(WorkflowChain chain) throws IOException {
     if (actionInvocation.action != null && actionInvocation.method == null) {
       Class<?> actionClass = actionInvocation.configuration.actionClass;
       logger.debug("The action class [{}] does not have a valid execute method for the HTTP method [{}]", actionClass.getCanonicalName(), method);
-      throw new NotAllowedException();
+
+      // Differentiate between not allowed for this action, vs no-implemented (supported by prime-mvc).
+      if (HTTPMethod.StandardMethods.containsKey(method.name())) {
+        throw new NotAllowedException();
+      }
+
+      // Note that the DefaultActionConfigurationBuilder will only resolve executeMethods for methods named in StandardMethods.
+      // See HTTPMethod.StandardMethods and DefaultActionConfigurationBuilder.findExecuteMethods
+      throw new NotImplementedException();
     }
 
     // Handle multipart file configuration

src/test/java/org/primeframework/mvc/GlobalTest.java

@@ -1465,7 +1465,11 @@ public void notAllowed() {
   public void notImplemented() {
     simulator.test("/not-allowed")
              .method("POTATO")
-             .assertStatusCode(405) // Not allowed since we can handle any name but the action doesn't have that method
+             // We currently only map out execute methods in the action that are named by a method
+             // defined in the HTTPMethod.StandardMethods. If an action does not define a standard HTTP
+             // method, a 405 will be returned. If you ask for a non-standard method that is not implemented
+             // by prime-mvc, you will receive a 501.
+             .assertStatusCode(501)
              .assertHeaderContains("Cache-Control", "no-cache");
   }