Skip to content

Incorrect RichTextField types #35

@nandorojo

Description

@nandorojo

Is your feature request related to a problem? Please describe.

Currently, the codegen outputs something like this for RichTextField:

declare type RichTextField<State extends FieldState = FieldState> = State extends "empty" ? [] : [RTNode, ...RTNode[]];

Using State extends "empty" ? [] means that the array is essentially never[] | [RTNode, ...RTNode[]]. This means that looping over items basically never works, because they can also be typed as never.

Screen Shot 2022-09-30 at 4 40 31 PM

Describe the solution you'd like

Rewrite the type like this:

declare type RichTextField<State extends FieldState = FieldState> = RTNode[];

An empty array doesn't require getting typed, right?

Describe alternatives you've considered

Overriding the types manually.

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions