In ICs_and_BCs.cc, the orientation of the elliptical twin seed is set based on the member field euler_angs of customPDE, which is in turn set in the phase field user input parameters file. For consistency, the twin orientation should be set based on the parent grain orientation and the twin normal and direction, as determined by the input grain orientation file, twin normals file, and twin directions file.
Alternatively, the field euler_angs and its associated user input parameter should be renamed and documentation added to make it clear that this value corresponds to the sample-frame orientation of the elliptical twin seed only.
In
ICs_and_BCs.cc, the orientation of the elliptical twin seed is set based on the member fieldeuler_angsofcustomPDE, which is in turn set in the phase field user input parameters file. For consistency, the twin orientation should be set based on the parent grain orientation and the twin normal and direction, as determined by the input grain orientation file, twin normals file, and twin directions file.Alternatively, the field
euler_angsand its associated user input parameter should be renamed and documentation added to make it clear that this value corresponds to the sample-frame orientation of the elliptical twin seed only.