Skip to content

Commit 2797c7c

Browse files
authored
Merge branch 'develop' into Harshit-7373/Solved-issue-#-2592
2 parents bb163d1 + dc17360 commit 2797c7c

File tree

8 files changed

+198
-192
lines changed

8 files changed

+198
-192
lines changed

client/styles/components/_p5-contrast-codemirror-theme.scss

+6-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ $p5-contrast-pink: #FFA9D9;
2525

2626
$p5-contrast-gutter: #454545;
2727
$p5-contrast-number: #FDFDFD;
28-
$p5-contrast-selected: rgba(45, 123, 182, 25);
28+
$p5-contrast-selected: $middle-dark;
2929
$p5-contrast-activeline: #999999;
3030

3131
.cm-s-p5-contrast {
@@ -81,8 +81,11 @@ $p5-contrast-activeline: #999999;
8181
color: $p5-contrast-number;
8282
}
8383

84-
.cm-s-p5-contrast div .CodeMirror-selected {
85-
background-color: $p5-contrast-selected;
84+
.cm-s-p5-contrast {
85+
.CodeMirror-selected { background: $p5-contrast-selected; }
86+
.CodeMirror-focused .CodeMirror-selected { background: $p5-contrast-selected; }
87+
.CodeMirror-line::selection, .CodeMirror-line > span::selection, .CodeMirror-line > span > span::selection { background: $p5-contrast-selected; }
88+
.CodeMirror-line::-moz-selection, .CodeMirror-line > span::-moz-selection, .CodeMirror-line > span > span::-moz-selection { background: $p5-contrast-selected; }
8689
}
8790

8891
.cm-s-p5-contrast .CodeMirror-activeline-background {

client/styles/components/_p5-dark-codemirror-theme.scss

+6-8
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ $p5-dark-goldbrown: #b58318;
2626

2727
$p5-dark-gutter: #f4f4f4;
2828
$p5-dark-number: #b5b5b5;
29-
$p5-dark-selected: rgba(45, 123, 182, 25);
29+
$p5-dark-selected: $medium-dark;
3030
$p5-dark-activeline: rgb(207, 207, 207);
3131

3232
$p5-dark-error: #df3a3d;
@@ -84,8 +84,11 @@ $p5-dark-error: #df3a3d;
8484
color: $p5-dark-number;
8585
}
8686

87-
.cm-s-p5-dark div.CodeMirror-selected {
88-
background-color: $p5-dark-selected;
87+
.cm-s-p5-dark {
88+
.CodeMirror-selected { background: $p5-dark-selected; }
89+
.CodeMirror-focused .CodeMirror-selected { background: $p5-dark-selected; }
90+
.CodeMirror-line::selection, .CodeMirror-line > span::selection, .CodeMirror-line > span > span::selection { background: $p5-dark-selected; }
91+
.CodeMirror-line::-moz-selection, .CodeMirror-line > span::-moz-selection, .CodeMirror-line > span > span::-moz-selection { background: $p5-dark-selected; }
8992
}
9093

9194
.cm-s-p5-dark .CodeMirror-activeline-background {
@@ -146,8 +149,3 @@ $p5-dark-error: #df3a3d;
146149
.cm-s-p5-dark .cm-searching {
147150
background-color: $p5js-pink-opacity;
148151
}
149-
150-
.cm-s-p5-dark .CodeMirror-selectedtext {
151-
background-color: $medium-dark;
152-
}
153-

client/styles/components/_p5-light-codemirror-theme.scss

+6-7
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ $p5-light-green: #47820A;
2323

2424
$p5-light-gutter: #f4f4f4;
2525
$p5-light-number: #b5b5b5;
26-
$p5-light-selected: rgba(45, 123, 182, 25);
26+
$p5-light-selected: $medium-light;
2727
$p5-light-activeline: rgb(207, 207, 207);
2828

2929
.cm-s-p5-light {
@@ -79,8 +79,11 @@ $p5-light-activeline: rgb(207, 207, 207);
7979
color: $p5-light-number;
8080
}
8181

82-
.cm-s-p5-light div .CodeMirror-selected {
83-
background-color: $p5-light-selected;
82+
.cm-s-p5-light {
83+
.CodeMirror-selected { background: $p5-light-selected; }
84+
.CodeMirror-focused .CodeMirror-selected { background: $p5-light-selected; }
85+
.CodeMirror-line::selection, .CodeMirror-line > span::selection, .CodeMirror-line > span > span::selection { background: $p5-light-selected; }
86+
.CodeMirror-line::-moz-selection, .CodeMirror-line > span::-moz-selection, .CodeMirror-line > span > span::-moz-selection { background: $p5-light-selected; }
8487
}
8588

8689
.cm-s-p5-light .CodeMirror-activeline-background {
@@ -139,7 +142,3 @@ $p5-light-activeline: rgb(207, 207, 207);
139142
.cm-s-p5-light .cm-searching {
140143
background-color: $p5js-pink-opacity;
141144
}
142-
143-
.cm-s-p5-light .CodeMirror-selectedtext {
144-
background-color: $medium-light;
145-
}

package-lock.json

+7-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

server/controllers/project.controller.js

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import JSZip from 'jszip';
22
import format from 'date-fns/format';
33
import isUrl from 'is-url';
44
import { JSDOM } from 'jsdom';
5+
import mime from 'mime';
56
import isAfter from 'date-fns/isAfter';
67
import axios from 'axios';
78
import slugify from 'slugify';
@@ -125,14 +126,18 @@ export async function getProjectAsset(req, res) {
125126
if (!resolvedFile) {
126127
return res.status(404).send({ message: 'Asset does not exist' });
127128
}
129+
const contentType =
130+
mime.getType(resolvedFile.name) || 'application/octet-stream';
128131
if (!resolvedFile.url) {
132+
res.set('Content-Type', contentType);
129133
return res.send(resolvedFile.content);
130134
}
131135

132136
try {
133137
const { data } = await axios.get(resolvedFile.url, {
134138
responseType: 'arraybuffer'
135139
});
140+
res.set('Content-Type', contentType);
136141
return res.send(data);
137142
} catch (error) {
138143
return res.status(404).send({ message: 'Asset does not exist' });

0 commit comments

Comments
 (0)